fix: rename untitled view

AppFlowy-IO · Nov 14, 2024 · f482d37 · f482d37
1 parent 555d08e
commit f482d37
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 5 deletions.
diff --git a/frontend/appflowy_flutter/lib/plugins/database/tab_bar/desktop/tab_bar_header.dart b/frontend/appflowy_flutter/lib/plugins/database/tab_bar/desktop/tab_bar_header.dart
@@ -236,7 +236,9 @@ class TabBarItemButton extends StatelessWidget {
           case TabBarViewAction.rename:
             NavigatorTextFieldDialog(
               title: LocaleKeys.menuAppHeader_renameDialog.tr(),
-              value: view.name,
+              value: view.name.isEmpty
+                  ? LocaleKeys.menuAppHeader_defaultNewPageName.tr()
+                  : view.name,
               onConfirm: (newValue, _) {
                 context.read<DatabaseTabBarBloc>().add(
                       DatabaseTabBarEvent.renameView(view.id, newValue),

diff --git a/...flutter/lib/workspace/presentation/home/menu/sidebar/favorites/favorite_more_actions.dart b/...flutter/lib/workspace/presentation/home/menu/sidebar/favorites/favorite_more_actions.dart
@@ -43,7 +43,9 @@ class FavoriteMoreActions extends StatelessWidget {
               NavigatorTextFieldDialog(
                 title: LocaleKeys.disclosureAction_rename.tr(),
                 autoSelectAllText: true,
-                value: view.name,
+                value: view.name.isEmpty
+                    ? LocaleKeys.menuAppHeader_defaultNewPageName.tr()
+                    : view.name,
                 maxLength: 256,
                 onConfirm: (newValue, _) {
                   // can not use bloc here because it has been disposed.

diff --git a/...flowy_flutter/lib/workspace/presentation/home/menu/sidebar/shared/rename_view_dialog.dart b/...flowy_flutter/lib/workspace/presentation/home/menu/sidebar/shared/rename_view_dialog.dart
@@ -26,7 +26,9 @@ Future<void> createViewAndShowRenameDialogIfNeeded(
   if (context.mounted && showRenameDialog) {
     await NavigatorTextFieldDialog(
       title: dialogTitle,
-      value: defaultName,
+      value: defaultName.isEmpty
+          ? LocaleKeys.menuAppHeader_defaultNewPageName.tr()
+          : defaultName,
       autoSelectAllText: true,
       onConfirm: createView,
     ).show(context);

diff --git a/frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart b/frontend/appflowy_flutter/lib/workspace/presentation/home/menu/view/view_item.dart
@@ -748,7 +748,9 @@ class _SingleInnerViewItemState extends State<SingleInnerViewItem> {
                 NavigatorTextFieldDialog(
                   title: LocaleKeys.disclosureAction_rename.tr(),
                   autoSelectAllText: true,
-                  value: widget.view.name,
+                  value: widget.view.name.isEmpty
+                      ? LocaleKeys.menuAppHeader_defaultNewPageName.tr()
+                      : widget.view.name,
                   maxLength: 256,
                   onConfirm: (newValue, _) {
                     context.read<ViewBloc>().add(ViewEvent.rename(newValue));

diff --git a/frontend/appflowy_flutter/lib/workspace/presentation/widgets/dialogs.dart b/frontend/appflowy_flutter/lib/workspace/presentation/widgets/dialogs.dart
@@ -105,7 +105,9 @@ class _NavigatorTextFieldDialogState extends State<NavigatorTextFieldDialog> {
   @override
   void initState() {
     super.initState();
-    newValue = widget.value;
+    newValue = widget.value.isEmpty
+        ? LocaleKeys.menuAppHeader_defaultNewPageName.tr()
+        : widget.value;
     controller.text = newValue;
     if (widget.autoSelectAllText) {
       controller.selection = TextSelection(