Improve key quantization and add command length #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmccormick
force-pushed
the
memcached-stuff
branch
from
f61d84d
to
393b236
Compare
jasonpenny
reviewed
Apr 17, 2024
| @@ -54,6 +54,9 @@ def request(op, *args) | |||
| cmd = Quantize.format_command(op, args) | |||
| span.set_tag(Ext::TAG_COMMAND, cmd) | |||
| end | |||
| # BEGIN BRAZE MODIFICATION | |||
| span.set_tag(Ext::TAG_LENGTH, Core::Utils.utf8_encode([op, *args].join(' ').strip, binary: true).length) | |||
There was a problem hiding this comment.
the Quantize.format_command(op, args) above
already ran Core::Utils.utf8_encode(command, binary: true, placeholder: placeholder)
I think it would be better to only run that once, the cost of this observability is pretty high already for the use of dalli, which gets used all the time.
Also, should this tag only be added when datadog_configuration[:command_enabled] is true?
Comment on lines
+30
to
+33
| command = command.gsub(GUID_ID_REGEX, "GUID") | ||
| command = command.gsub(BSON_ID_REGEX, "BSON") | ||
| command = command.gsub(XXHASH_REGEX, "XXHASH") | ||
| command = command.gsub(INTEGER_ID_REGEX, "INTEGER") |
There was a problem hiding this comment.
this could have negative perf impact, also
There was a problem hiding this comment.
I don't think this will be too bad, but I'm curious if there are some relatively quick ideas we could do to make this faster. I could smush all of these together into a single expression and just replace it with ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow us to quantize the keys better.
Also provides a new LENGTH tag on the spans to help identify large cached items better