Upgrade to 2.3 #20
Open
Upgrade to 2.3 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamic instrumentation will use the TokenBucket rate limiter. To facilitate this, the basic rate limiters are being moved from tracing to core. Co-authored-by: Oleg Pudeyev <[email protected]>
This addresses the deprecation warning that `ostruct` will not be part of standard library since ruby 3.5
…warning Add ostruct to Gemfile for Ruby >= 3.3.5
Add build-harness and build-apps to the list of needs for aggregate job so it won't run if a build job fails Co-authored-by: Oleg Pudeyev <[email protected]>
The only usage of token bucket rate limiter currently in our code uses a size of 1 (to perform one action). Default the size parameter to 1 to simplify the API for using token bucket on the caller side. Dynamic instrumentation will also use token bucket and will also call allow? with the size of 1. Co-authored-by: Oleg Pudeyev <[email protected]>
…y-deadlock Fix deadlock when sending telemetry logs
…t-update-task Add Github Token as argument to `appsec:ruleset:update` task
…r_version_for_telemetry_with_ci [SDTEST-756] add +ci-X.Y.Z to the tracer_version reported to internal telemetry if datadog-ci is present and CI mode is enabled
…stone-workflow [NO-TICKET] add missing permissions for add-milestone gha workflow
Improve brittle assertion
…nOperation when get_time_provider is set
This configuration is frequently failing due to HTTP 503 error when installing valgrind. Retry the installation one time after a short break to see if this would make the configuration less flaky.
* DEBUG-2334 upgrade steep & rbs * return appsec settings to correct type signature and exclude the file from steep --------- Co-authored-by: Oleg Pudeyev <[email protected]>
…c_time_provider [SDTEST-482] Add get_time_provider setting to avoid timecop mocking the clock_gettime
Retry apt-get install for memory-leaks config
Rescue instrumentation errors
Test `rack` latest
…e-test Remove benchmarks never ran.
…DataDog#3955) Dynamic instrumentation will not work on Ruby 2.5 and JRuby. Some unit tests will pass on those configurations, but there is no reason to run them there because they run on all of the supported configurations already. Co-authored-by: Oleg Pudeyev <[email protected]>
jasonpenny
requested changes
Sep 26, 2024
There was a problem hiding this comment.
In my opinion, there will need to be a whole project around this to make sure our previous fork changes still work, and our monkey-patches in platform still work, etc., and I don't think it's even on PLATI's radar.
And there is another upgrade guide https://github.com/DataDog/dd-trace-rb/blob/release/docs/UpgradeGuide2.md since this has breaking changes
|
yeah I'm working through that stuff right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only had to resolve a minor conflict in grape/endpoint.rb