Add support for dismissing notifications #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ability to dismiss a notification if it expires or for other reason.
One thing I noticed is that the "Timeout" option doesn't actually appear to do anything (and couldn't find any documentation that indicated such a parameter exists), so I needed a way to actually dismiss a notification when it expired.
This is potentially a breaking change because it changes the return type of the CreateAsync methods. I re-used the Notification class that seemed to be unused as the return type (since it mostly had some useful data on it already) and added a Close method to pass to the javascript method with the same name.
Only part I wish was a bit cleaner is that the Notification has to be disposable, due to IJSObjectReference itself being disposable. Possibly there should be two ways to call it, one if you want the notification back and one if you don't.