Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need help notice #1057

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

Need help notice #1057

wants to merge 48 commits into from

Conversation

EffBureau
Copy link
Contributor

@EffBureau EffBureau commented Sep 23, 2024 •
edited by Spoodern0t
Loading

⁉️ Related Issue

No related issue

📖 Description

Add a dialog to warn users that we cannot help them gain access to their accounts.

🧪 How Has This Been Tested?

Manually
Added unit test to check if dialog shows up
Added unit test to check if cancel closes dialog
Added unit test to check if tap outside dialog closes it
Added unit tests to check if password assistance urls work

☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • [N/A] If it is a core feature, I have added thorough tests.
  • If needed, I added analytics. // I added analytics to see if the dialog is actually useful and how many times it has been used
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.

🖼️ Screenshots (if useful):

image

@EffBureau EffBureau requested a review from a team as a code owner September 23, 2024 15:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

XavierPaquet-Rapold
XavierPaquet-Rapold requested changes Nov 8, 2024
View reviewed changes
@github-actions github-actions bot added size: XL and removed size: M labels Jan 6, 2025
@github-actions github-actions bot removed the size: XL label Jan 6, 2025
XavierPaquet-Rapold
XavierPaquet-Rapold requested changes Jan 15, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@EffBureau EffBureau self-assigned this Feb 3, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

Coverage after merging need-help-notice into master will be

72.43%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib
   locator.dart4.55%100%100%4.55%28, 30–38, 41–47, 50–53
lib/data/models
   quick_link.dart100%100%100%100%
   quick_link_data.dart100%100%100%100%
   mon_ets_user.dart50%100%100%50%29–33, 35, 37
   quick_links.dart100%100%100%100%
   emergency_procedures.dart100%100%100%100%
   emergency_procedure.dart100%100%100%100%
lib/data/models/hello
   organizer.dart100%100%100%100%
   paginated_news.dart31.03%100%100%31.03%36–41, 44, 47–53, 55, 57–61
   activity_area.dart48.15%100%100%48.15%35, 38–44, 46, 48–52
   news.dart50.88%100%100%50.88%100–101, 103, 105–116, 85, 88–99
   news_tags.dart5%100%100%5%17–21, 23–27, 30, 33–38, 40, 42
   report.dart14.29%100%100%14.29%15–17, 20–22
   report_news.dart100%100%100%100%
lib/data/repositories
   author_repository.dart0%100%100%0%13, 15
   course_repository.dart84.34%100%100%84.34%200, 205, 210–211, 213, 217, 219–220, 223–229, 234, 236, 239, 241–243, 246–251, 255, 259–261, 263, 267, 337, 345, 347, 532–533, 83
   news_repository.dart0%100%100%0%16, 21
   quick_link_repository.dart85.71%100%100%85.71%39–40
   settings_repository.dart87.38%100%100%87.38%188, 194, 197, 201, 203, 221, 223–224, 236, 238–239, 37, 86
   user_repository.dart93.52%100%100%93.52%135–136, 186, 308, 310, 98–99
   login_mask.dart5%100%100%5%12, 15–16, 18–20, 23–30, 33–34, 37–39
lib/data/services
   analytics_service.dart0%100%100%0%13–14, 17, 20–22, 25, 30, 32–34, 38, 40–41, 43
   cache_service.dart0%100%100%0%30–31, 34–37, 40, 44, 46–50, 56, 58–61, 66, 68–71
   in_app_review_service.dart0%100%100%0%16, 20, 23, 27
   internal_info_service.dart0%100%100%0%18–21, 24–29, 32, 34–38, 42–43
   launch_url_service.dart0%100%100%0%14–17, 19, 23–26, 28, 32–35, 40, 44
   navigation_service.dart0%100%100%0%100, 102–103, 32, 35–36, 38–39, 46–47, 50–51, 54–56, 58, 63, 65, 68–69, 72–74, 77–79, 82, 84, 89, 92, 94–95, 98–99
   remote_config_service.dart0%100%100%0%100–101, 104–106, 109–111, 114–116, 119–121, 124–126, 129–131, 134–136, 139–141, 144–145, 147–151, 155–157, 59–61, 64–66, 69–71, 74–76, 79–81, 84–86, 89–91, 94–96, 99
   networking_service.dart0%100%100%0%10–11, 13–15, 18–20
   preferences_service.dart63.64%100%100%63.64%112–113, 115, 29, 31, 33, 36–38, 51, 60–63, 73–75, 78, 80–81
   calendar_service.dart0%100%100%0%100, 104–106, 112, 116, 118–122, 124–125, 127, 130–133, 139–140, 143, 146, 15, 150, 157, 162, 165, 167, 17, 172, 176–177, 181–183, 185–187, 19, 191, 195, 21–22, 25, 27, 29, 43–44, 46–47, 49–50, 53, 57–60, 68, 71–72, 75, 80, 83, 89, 91–92, 95, 99
   navigation_history_observer.dart0%100%100%0%11–12, 15–18, 20, 22, 24, 27, 29, 32, 34
lib/data/services/hello
   hello_service.dart91.67%100%100%91.67%26
lib/data/services/hello/commands
   get_events_command.dart74.07%100%100%74.07%50, 58, 61, 64, 67, 70, 73
   get_organizer_command.dart92.31%100%100%92.31%26
   report_news_command.dart92.86%100%100%92.86%27
lib/data/services/monets
   monets_api_client.dart90.91%100%100%90.91%22
lib/data/services/signets-api
   signets_api_client.dart88.89%100%100%88.89%35, 45, 47, 49
   soap_service.dart100%100%100%100%
lib/data/services/signets-api/commands
   authentificate_command.dart0%100%100%0%18, 21, 24–28, 31
   get_course_reviews_command.dart100%100%100%100%
   get_course_summary_command.dart100%100%100%100%
   get_courses_activities_command.dart100%100%100%100%
   get_courses_command.dart100%100%100%100%
   get_programs_command.dart100%100%100%100%
   get_schedule_activities_command.dart100%100%100%100%
   get_sessions_command.dart100%100%100%100%
   get_student_info_command.dart100%100%100%100%
lib/data/services/signets-api/models
   course.dart80.52%100%100%80.52%102–105, 120, 122–131
   course_activity.dart81.40%100%100%81.40%83, 85–91
   schedule_activity.dart80.95%100%100%80.95%121, 123–133
   session.dart73.08%100%100%73.08%159, 161–173, 175, 177–189
   profile_student.dart82.14%100%100%82.14%56, 58–61
   program.dart81.13%100%100%81.13%100–106, 96, 98–99
   course_review.dart51.92%100%100%51.92%100–103, 51–58, 70, 72–79, 95, 97–99
   course_summary.dart86.84%100%100%86.84%106, 108–116
   course_evaluation.dart70.54%100%100%70.54%128, 167, 169–182, 184, 186–200, 49
lib/domain/constants
   preferences_flags.dart0%100%100%0%39, 44, 46, 48, 51, 53–56, 58, 60
   markers.dart100%100%100%100%
lib/ui/core/themes
   app_palette.dart100%100%100%100%
   app_colors_extension.dart1.52%100%100%1.52%100–107, 109–110, 112–128, 131, 133, 138, 142–152, 154, 156–169, 171, 173–176, 66, 97–99
   app_theme.dart14.55%100%100%14.55%100–101, 104–105, 107, 11, 112, 114, 116, 122–123, 13–14, 142–143, 15, 18–19, 21–23, 25, 27–29, 32–35, 37–39,

XavierPaquet-Rapold
XavierPaquet-Rapold approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@XavierPaquet-Rapold XavierPaquet-Rapold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

LouisPhilippeHeon
LouisPhilippeHeon requested changes Mar 8, 2025
View reviewed changes
lib/ui/core/ui/need_help_notice_dialog.dart
super.key,
required this.openMail,
required this.launchWebsite,
this.radius = 5.0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

border radius de 8.0

lib/ui/core/ui/need_help_notice_dialog.dart

@override
Widget build(BuildContext context) => AlertDialog(
title: Text(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shape: RoundedRectangleBorder(borderRadius: BorderRadius.circular(16)),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouisPhilippeHeon LouisPhilippeHeon LouisPhilippeHeon requested changes

@XavierPaquet-Rapold XavierPaquet-Rapold XavierPaquet-Rapold approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@EffBureau EffBureau

Labels
size: M version: Minor
Projects
Kanban
Status: Review in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EffBureau @XavierPaquet-Rapold @LouisPhilippeHeon