Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/components set 4 #24

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Feature/components set 4 #24

merged 3 commits into from
Jun 30, 2022

Conversation

filipakkad
Copy link
Contributor

@filipakkad filipakkad commented Jun 24, 2022 •
edited by kamilzyla
Loading

This PR depends on #20. Please review and merge it first.

PR checklist

  • Add E2E test / update the testing status in the spreadsheet
  • The component has a usage example as a Shiny module
  • The status of the component has been updated in the spreadsheet
  • It has been verified if the component requires a Shiny wrapper, the status updated in the spreadsheet
  • Add a link to the Blueprint documentation

Components:

  • Alert
  • Drawer
  • Popover fix in the demo app

@filipakkad filipakkad requested a review from kamilzyla June 24, 2022 12:54
@filipakkad filipakkad force-pushed the feature/components-set-4 branch from fbd9799 to 02d5445 Compare June 24, 2022 12:56
@kamilzyla kamilzyla changed the base branch from main to feature/components-set-3 June 28, 2022 13:42
kamilzyla
kamilzyla approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@kamilzyla kamilzyla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🎉

man/Alert.Rd Show resolved Hide resolved
inst/examples/components/Popover.R Show resolved Hide resolved
@filipakkad filipakkad force-pushed the feature/components-set-4 branch from 02d5445 to 9ce6eb7 Compare June 30, 2022 10:12
Base automatically changed from feature/components-set-3 to main June 30, 2022 10:14
@filipakkad filipakkad merged commit 75abaae into main Jun 30, 2022
@filipakkad filipakkad deleted the feature/components-set-4 branch June 30, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilzyla kamilzyla kamilzyla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipakkad @kamilzyla