Skip to content

prepare for universal build and CMake 4 #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: next_release
Choose a base branch
from

Conversation

rjsatpdftron
Copy link

To work propper with CMake4 the cmake_minimum_required should be at least 3.10.

PDFNetRuby/CMakeLists.txt adjusted to create universal (arm64;x86_64) binaries.

To work propper with CMake4 the cmake_minimum_required should be
at least 3.10.

PDFNetRuby/CMakeLists.txt adjusted to create universal (arm64;x86_64)
binaries.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates CMake configuration files to prepare for CMake 4 compatibility and enable universal binary builds. The changes standardize the minimum CMake version requirement and simplify macOS architecture targeting.

  • Updates minimum CMake version from 2.8.12 to 3.10 across all CMakeLists.txt files
  • Replaces conditional ARM64 build logic with universal architecture setting for macOS
  • Removes complex conditional CMake version checking in the root CMakeLists.txt

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
PDFTronGo/CMakeLists.txt Updates minimum CMake version to 3.10
PDFNetRuby/CMakeLists.txt Updates CMake version and replaces ARM64-specific build flags with universal architecture setting
PDFNetPHP/CMakeLists.txt Updates minimum CMake version to 3.10
CMakeLists.txt Simplifies CMake version requirement by removing conditional logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant