[Bug] fix log buffer inital issue #453
Conversation
|
Hi @ocean-dot-li ~ Thanks for your contribution in this PR. ❤️ Please make sure that your PR conforms the standard, and has passed all the checks. We will review your PR as soon as possible. |
|
Hey @ocean-dot-li : Congratulations~ 🎉 Your commit has passed all the checks. Please wait for further manual review. |
src/backend/tcop/postgres.c
Outdated
| @@ -2354,13 +2354,15 @@ exec_execute_message(const char *portal_name, long max_rows) | |||
| pq_putemptymessage('s'); | |||
| } | |||
|
|
|||
| /* POLAR: inital buf used by logging info. */ | |||
There was a problem hiding this comment.
Would it be better to initialize the buf.data here, and keep the initStringInfo at where it originally be? Because not all path needs to use buf.data, allocate memory here for all path seems wasteful.
buf.data = NULL;In exec_execute_message(), we should initalize the log buffer at outermost layer. If not, crash may happen when trying to accessing its data member. This patch fixes the issue.
ocean-dot-li
force-pushed
the
bug_fix_log_buf_issue
branch
from
04ca783 to
3e4344b
Compare
|
Hey @ocean-dot-li : Congratulations~ 🎉 Your commit has passed all the checks. Please wait for further manual review. |
polardb-bot
bot
added
ci/success
|
/rebase-and-merge |
|
@mrdrivingduck PR has been merged. 🍗 Thanks again for the contributors involved in this thread: ❤️ |
In exec_execute_message(), we should initalize the log buffer at outermost layer. If not, crash may happen when trying to pfree its data member.
This patch fixes the issue.