[AND-37] Change permission flow #2066
Open
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Culurio
force-pushed
the
feature/AND-37_Change-permission-flow
branch
from
eb83e32
to
feef537
Compare
GuiFPires
approved these changes
Nov 6, 2024
G0retZ
requested changes
Nov 6, 2024
| @@ -32,7 +32,6 @@ class AptoideDownloader @Inject constructor( | |||
| if(installPackageInfo.hasObb()) { | |||
| installPermissions.checkIfCanWriteExternal() | |||
| } | |||
| installPermissions.checkIfCanInstall() | |||
There was a problem hiding this comment.
I don't think we should do this, as this could break the installations
There was a problem hiding this comment.
@G0retZ we check on the installations part, as it's done on vanilla. After the app is downloaded, the installation flow starts and if the user doesn't have install unknown sources permission, our dialog for the install unknown sources will appear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR aims to only ask for unknown sources permission only after the download
Database changed?
No
Where should the reviewer start?
How should this be manually tested?
Flow on how to test this or QA Tickets related to this use-case: AND-37
What are the relevant tickets?
Tickets related to this pull-request: AND-37
Questions:
Does this add new dependencies which need to be added? (Eg. new keys, etc.)
Code Review Checklist