-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kingdom Hearts: Implement New Game #3201
base: main
Are you sure you want to change the base?
Conversation
Added Final Ansem Goal
Logic Fixes
Ansem's Report Logic
Oathkeeper Logic Fix
…native win condition settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty simple and nice to review overall, seems to be working as well
I have many nitpicks and some genuine issues
As usual, any comments where the last line is "low priority" or some other note in italics, I'm okay if you just resolve them and don't change anything. (Especially "comment", where there's no suggested change)
On the other ones, I'd at least like a reply on why you don't think it's a good idea if you end up rejecting it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick rereview - Couple of things still stuck out to me, but overall I think it's greatly improved now :)
Co-authored-by: Exempt-Medic <[email protected]>
Co-authored-by: Exempt-Medic <[email protected]>
Oh, you're also failing unit tests now, apparently there is a bug in your create_items? Might wanna do a test gen and see if it crashes |
Found where this was happening, had to do with a change above involving the |
Thank you for your patience & cooperation so far, we're getting close I promise :) Gonna do a rereview now, with any luck it's the last |
What is this fixing or adding?
Adds Kingdom Hearts (EGS and Steam PC) as a playable game in AP
How was this tested?
Many test runs in unsupported games, both sync and async.