LADX: Zig's Entrance Rando PR with some cleaning and merging #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # worlds/ladx/LADXR/locations/startItem.py # worlds/ladx/LADXR/patches/core.py # worlds/ladx/Options.py # worlds/ladx/__init__.py
ScipioWright
added
is: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
#1613
This PR, mainly, with the merge conflicts fixed since Zig said they didn't want to maintain LADX anymore.
Permission to redo their PR: https://discord.com/channels/731205301247803413/1090819435893362768/1254118472741552188
I have not reviewed to make sure this actually works, other than the previous review I did before (in the comments on the old PR), and the checking that I did to make sure it functions now.
Also, it is hitting that memory leak assert, which is why it's a draft for now. Need to find some time to figure that out.
And hitting a fill error sometimes, which also needs to be fixed.
If others want to fix the issues here, please, please feel free to do so. I've already spent longer on this than I wanted to, and I haven't had the drive to fix more recently.
How was this tested?
Few test gens. More testing is absolutely needed.
If this makes graphical changes, please attach screenshots.
N/A