LADX: Adding Slot Data For Magpie Tracker #3582
Open
+52
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
…Archipelago into LADX-slot_data_extension
Exempt-Medic
added
the
is: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Slot data which contains player settings are added to the player data. These will be used to be shown in Magpie tracker. So these changes are the base for that.
How was this tested?
Generating local seeds and testing communication with Magpie tracker. @kbranch added a short test feature to validate data are sent to Magpie and tracker grabs these. Format is also the communicated one.
Slot data are sent as dict to Magpie.
If a seed has no slot data (i.e. from an older generating) there will be sent an empty dict.
If this makes graphical changes, please attach screenshots.
No visual changes on AP but in the next step on Magpie.