Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raft: Move to new Options API #3587

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Raft: Move to new Options API #3587

wants to merge 4 commits into from
+45 −38

Conversation

SunnyBat
Copy link
Collaborator

@SunnyBat SunnyBat commented Jun 24, 2024 •
edited
Loading

What is this fixing or adding?

This moves Raft off of the old deprecated Options API and on to the new Options API to address #3284

How was this tested?

Manually. Made sure logical values were still being respected via debugging during generation. Ran with multiple different options.

If this makes graphical changes, please attach screenshots.

N/A

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 24, 2024
@NewSoupVi NewSoupVi added the is: refactor/cleanup Improvements to code/output readability or organizization. label Jun 24, 2024
@NewSoupVi NewSoupVi mentioned this pull request Jun 24, 2024
Open
65 tasks
beauxq
beauxq approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@beauxq beauxq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like all the changes are correct (I don't know the game, just the options api)

ScipioWright
ScipioWright approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a little cleaner, but nothing here is stopping me from approving

worlds/raft/__init__.py Outdated Show resolved Hide resolved
worlds/raft/__init__.py Outdated Show resolved Hide resolved
worlds/raft/__init__.py Outdated Show resolved Hide resolved
worlds/raft/__init__.py Outdated Show resolved Hide resolved
@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beauxq beauxq beauxq approved these changes

@NewSoupVi NewSoupVi NewSoupVi left review comments

@ScipioWright ScipioWright ScipioWright approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SunnyBat @beauxq @ScipioWright @NewSoupVi