Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add FFMQ French Setup Guide + Minor fixes to English Guide #3590

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

wildham0
Copy link
Contributor

What is this fixing or adding?

Adding a French Setup Guide for Final Fantasy Mystic Quest and making some minor fixes to the English Guide.

How was this tested?

n/a

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jun 25, 2024
@Exempt-Medic Exempt-Medic added the is: documentation Improvements or additions to documentation. label Jun 25, 2024
Copy link
Contributor

@Jouramie Jouramie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some typos to fix. The rest of the comments are mostly just style nitpicking. LGTM

Comment on lines +38 to +39
setup_en.tutorial_name,
setup_en.description,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Une raison de ne pas traduire le nom et la description? Si je compare avec DLCQuest et Aquaria, ça a été traduit. Aucune idée si ça change réellement quelque chose par contre.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai vu un autre jeu (witness?) qui ne les traduisait pas et je n'ai rien trouvé qui utilise ces valeurs au-delà de la première langue disponible, à moins d'instructions claires du contraire je vais le garder comme ça

worlds/ffmq/docs/fr_Final Fantasy Mystic Quest.md Outdated Show resolved Hide resolved
worlds/ffmq/docs/fr_Final Fantasy Mystic Quest.md Outdated Show resolved Hide resolved
worlds/ffmq/docs/fr_Final Fantasy Mystic Quest.md Outdated Show resolved Hide resolved
worlds/ffmq/docs/fr_Final Fantasy Mystic Quest.md Outdated Show resolved Hide resolved
worlds/ffmq/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/ffmq/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/ffmq/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/ffmq/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/ffmq/docs/setup_fr.md Outdated Show resolved Hide resolved
wildham0 and others added 24 commits July 3, 2024 07:35
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Co-authored-by: Jérémie Bolduc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants