Core: "Fix" Priority Fill #3592
Draft
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
affects: core
github-actions
bot
added
the
waiting-on: peer-review
|
Really would like to see this get in, not just because the Shivers option we want to add... but seeing as 5.0 added the slew of options and group being priority locations... this might be important for anyone using those? I mean like if I do this, this should be exactly what the option would be, which should run into the exact same issue we had with failed gens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the related issue: #3467
Also, this was done on 0.4.5 because it might be needed for "The Longest Async", which is rolled on 0.4.5.
That's why it has conflicts.
I'm mostly opening this PR bc I already made the change anyway, so why not. You can look at the diff, and we can discuss it.
Basically, this makes the "grab one item per player" optimisation of Fill optional, and then makes priority fill not use it. This fixes "I want all my late game locations to be priority" failing at an extremely high rate.