Launcher: Update message that displays when installing a custom apworld for a game in main #3607
Conversation
github-actions
bot
added
affects: core
worlds/LauncherComponents.py
Outdated
| @@ -131,8 +131,9 @@ def _install_apworld(apworld_src: str = "") -> Optional[Tuple[pathlib.Path, path | |||
| found_already_loaded = True | |||
| break | |||
| if found_already_loaded: | |||
| raise Exception(f"Installed APWorld successfully, but '{module_name}' is already loaded,\n" | |||
| "so a Launcher restart is required to use the new installation.") | |||
| raise Exception(f"Installed APWorld successfully, but '{module_name}' is already installed,\n" | |||
There was a problem hiding this comment.
I don't like this change from "loaded" to "installed".
After #3226, it could be installed and not require a restart because it's not loaded.
So what matters is that it's loaded, not that it's installed.
There was a problem hiding this comment.
After #3226, the message will need to be changed to omit the restart bit anyway.
In my eyes, if I saw just that message without having the launcher open, and it said loaded, I'd be a little confused since I don't have anything "loaded" atm.
If I saw that message with the launcher open, and it said installed, I would understand what it meant.
There was a problem hiding this comment.
After #3226, the message will need to be changed to omit the restart bit anyway.
Why? That doesn't provide a way to unload worlds, so it would still need to be restarted if the world is loaded.
There was a problem hiding this comment.
Ah, my mistake, I didn't read through that pr thoroughly enough.
The rest of the response still stands, though.
There was a problem hiding this comment.
Supporting the user's incorrect ideas is not a good way to avoid confusion.
If the user is thinking they don't have anything loaded when they see this, that idea is just wrong.
There was a problem hiding this comment.
I'm going to change it to your suggestion. I don't agree with it still, but it's way too much time spent on a single word.
There was a problem hiding this comment.
This is an ok temporary workaround.
A better solution would be to have a way to tell this apworld installer whether it's being called with the GUI open, so it doesn't need to display any message at all with no Launcher GUI. But that would require a more significant and dangerous change.
ScipioWright
added
waiting-on: core-review
What is this fixing or adding?
When double-clicking a beta Tunic apworld, I got the above message. I did not have the regular Launcher open, so I could see this being confusing for some users.
So, this PR updates the message that displays to hopefully be a bit clearer.
How was this tested?
Reading