Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommonClient: fix bug when using Connect button without a disconnect #3609

Merged
merged 2 commits into from
Jul 21, 2024
Merged

CommonClient: fix bug when using Connect button without a disconnect #3609

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb03f33
makes the kivy connect button do the same username forgetting that /c…
qwint Jul 3, 2024
8074074
extract duplicate code
qwint Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions kvui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,7 @@ def connect_button_action(self, button):
self.ctx.username = None
async_start(self.ctx.disconnect())
else:
self.ctx.username = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since self.ctx.username = None is in both branch of the if self.ctx.server, would it be better to extract it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't notice this haha, fixed

async_start(self.ctx.connect(self.server_connect_bar.text.replace("/connect ", "")))

def on_stop(self):
Expand Down
Loading