Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project: Add .code-workspace wildcard to gitignore #3615

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JKLeckr
Copy link

@JKLeckr JKLeckr commented Jul 3, 2024

What is this?

This replaces .code-workspace with *.code-workspace in the root .gitignore

Why is this needed?

VSCode, these days, by default, names the workspace file foldername.code-workspace. This change will make life a little easier by no longer requiring vscode users explicitly save the workspace as .code-workspace

How will this affect the project?

This will enhance developer experience. It is unlikely that adding a wildcard to .code-workspace would negatively affect or break the project. It was verified that there wasn't any other files that contained ".code-workspace" in the github project.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jul 3, 2024
@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Jul 10, 2024
@BadMagic100
Copy link
Collaborator

Seems reasonable to me

@BadMagic100 BadMagic100 added is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants