Stardew Valley: Fix Art Of Crabbing Logic and Extract Festival Logic #3625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
the
is: bug/fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
The Art of crabbing book in content pack relies on the festival being winnable, which is the vanilla rule for it. But when festivals are shuffled, the book is an AP item instead. This changes the rule to be conditional, either get the book if shuffled festivals, or win if not.
Furthermore, took this opportunity to extract festival logic code into a dedicated file to be slightly cleaner
Note: While this is a bug, it is not a critical bug, because that book also has a bookseller source, which is available in year 3 on all setting combinations. Therefore the bug can delay a player, but it cannot softlock them. Annoyance-tier bug :)
How was this tested?
Automated tests plus a manual gen each way.