CommonClient: forget password when disconnecting #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnect does to fix an issue where losing connection would make you unable to connect to a different server
…word as to not leak it to other servers
github-actions
bot
added
affects: core
|
Does this supercede #3609? |
Jouramie
approved these changes
Jul 19, 2024
Exempt-Medic
added
waiting-on: core-review
NewSoupVi
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
followup to #3609
this adds to the disconnect workflows clearing out of the password field
How was this tested?
wasn't; will probably at least run through connect/disconnect later sometime
would want some input from people who run password'd games more often to see if these changes make swapping slots etc. too frustrating to see if an alternative solution is needed
If this makes graphical changes, please attach screenshots.