Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused Xserver/miext/cw #439

Open
wants to merge 2 commits into
base: 3.6.x
Choose a base branch
from

Conversation

sunweaver
Copy link
Member

Xserver/miext/cw: Remove. The nxagent Xserver was never a consumer.

This change lets nxagent segfault in fb/fbsolid.c if the Composite
extension gets enabled (nxagent +extension Composite :).

However, as Composite support is broken anyway, currently, let's
approach Composite support without the deprecated CompositeWrapper.

…. Never used by nxagent (only consumer: XAA).

 Picked from the below X.org commit:

 commit 6ed08949af4f7ac09170d3d9581e4092b24a84ee
 Author: Eric Anholt <[email protected]>
 Date:   Tue Mar 27 17:31:28 2007 -0700

    Move libcw setup to the only renderer requiring it (XAA).

    Additionally, protect libcw setup behind checks for Render, to avoid
    segfaulting if Render isn't available (xnest).

    The previous setup was an ABI-preserving dance, which is better nuked now.
    Now, anything that needs libcw must explicitly initialize it, and
    miDisableCompositeWrapper (previously only called by EXA and presumably binary
    drivers) is gone.
 This change lets nxagent segfault in fb/fbsolid.c if the Composite
 extension gets enabled (nxagent +extension Composite :<disp>).

 However, as Composite support is broken anyway, currently, let's
 approach Composite support without the deprecated CompositeWrapper.

 Backported from X.org:

 commit a44a379a2a4c198dbd6ffd6cc0db376f8fb64327
 Author: Adam Jackson <[email protected]>
 Date:   Thu Jul 19 15:00:03 2012 -0400

    cw: Remove

    XAA was the only consumer.

    Signed-off-by: Adam Jackson <[email protected]>
    Reviewed-by: Dave Airlie <[email protected]>
    Reviewed-by: Alan Coopersmith <[email protected]>
    Reviewed-by: Alex Deucher <[email protected]>
    Reviewed-by: Daniel Stone <[email protected]>
    Acked-by: Aaron Plattner <[email protected]>
    Signed-off-by: Keith Packard <[email protected]>

 Backported-to-NX-by: Mike Gabriel <[email protected]>
@sunweaver sunweaver requested a review from Ionic April 19, 2017 13:06
@sunweaver sunweaver self-assigned this Apr 19, 2017
@sunweaver sunweaver added this to the 3.6.0.0 milestone Apr 19, 2017
Copy link
Member

@Ionic Ionic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically okay, but do we want to ignore the segfault?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants