remove -full, making FullGeneration the default #485
Conversation
Are you sure, we want this? From the man page of Xnest as quoted in #191, I get the impression that making nxagentFullGeneration the default could create a lot of extra round trips (as the full generation happens betweem local Xserver and nxagent Xserver)... Have you checked this with xtrace? |
|
I have not checked this. AFAIU this is only needed when you close all clients. Normally Xnest will stay alive and not close down the Display connection. With FullGeneration it will close it and build a new one and then await new clients. I am unsure now if that case ever happens in nxagent. We have -reset/-noreset, -once and -full. And we have nxagent quitting when the last client disconnects. Must think through this, help appreciated. In any case we need a FullGeneration at the startup. So this seems like the natural default. |
|
Hi Uli,
On Mi 12 Jul 2017 13:20:22 CEST, Ulrich Sibiller wrote:
I have not checked this. AFAIU this is only needed when you close
all clients. Normally Xnest will stay alive and not close down the
Display connection. With FullGeneration it will close it and build a
new one and then await new clients.
I am unsure now if that case ever happens in nxagent. We have
-reset/-noreset, -once and -full. And we have nxagent quitting when
the last client disconnects. Must think through this, help
appreciated.
hmmm... Basically, I'd suggest removing -full and leaving the default
as if nxagentFullGeneration was False.
In any case we need a FullGeneration at the startup. So this seems
like the natural default.
Note, that nxagentDoFullGeneration is always True at agent startup.
(see Init.c).
nxagentFullGeneration is a static flag obtained from Args.c, where
nxagentDoFullGeneration adapts to the situation at runtime.
Mike
…--
DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31
mail: [email protected], http://das-netzwerkteam.de
|
|
I am aware of that code. But if I keep all that logic this patch does not make any sense, as I have to keep most of the code. |
|
Well, I must check if any benefit remains after doing it as proposed above. Also my initial bug report #191 does not seem appropriate anymore, I cannot trigger the described behaviour. Can you? |
|
@uli42: ping(?) |
|
Aehm, my last queytion was, if you can trigger the fullscreen behaviour described in #191. So I'd better ping you ;-) |
|
@uli42: No, I can't reproduce "-full" switching nxagent to full screen mode. Tested against i3wm and marco WM (from MATE). |
|
@uli42: You just updated the -full option in the man page. Is this PR obsolete? Shall -full stay? |
|
Well, I just added the text from xnest explaining what the switch should do. As long as we have it we should also include it in the manpage. I have not looked any further regarding this pr |
|
On Mi 19 Dez 2018 13:21:56 CET, Ulrich Sibiller wrote:
Well, I just added the text from xnest explaining what the switch
should do. As long as we have it we should also include it in the
manpage. I have not looked any further regarding this pr
Ok.
Mike
--
DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31
mail: [email protected], http://das-netzwerkteam.de
|
|
sigh... I am sorry, but pr/drop-full-generation got forgotten meanwhile. It should still be merged, I guess. Please rebase. Thanks. |
Addresses #191