Skip to content

Commit

Permalink
block EdgarRenderer from processing invalid facts
Browse files Browse the repository at this point in the history
  • Loading branch information
hefischer committed Mar 20, 2024
1 parent 510fa3a commit 97ca386
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions Filing.py
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,9 @@ def factSortKey (fact):
linesDiscarded=', '.join(discardedLineNumberList))

for fact in factSet: # we only want one thing, but we don't want to pop from the set so we "loop" and then break right away
if fact.concept is None:
if getattr(fact,"xValid", 0) < VALID:
continue
elif fact.concept is None:
if not self.validatedForEFM:
self.modelXbrl.error("xbrl:schemaImportMissing", # use standard Arelle message for this
_("Instance fact missing schema definition: %(elements)s"),
Expand Down Expand Up @@ -509,7 +511,7 @@ def factSortKey (fact):
self.usedOrBrokenFactDefDict[fact].add(None) #now bad fact won't come back to bite us when processing isUncategorizedFacts
continue # fact was rejected in first loop of this function because of problem with the Element

if fact.xValid < VALID:
if getattr(fact,"xValid", 0) < VALID:
self.usedOrBrokenFactDefDict[fact].add(None) #now bad fact won't come back to bite us when processing isUncategorizedFacts
continue

Expand Down

0 comments on commit 97ca386

Please sign in to comment.