feat: add entrypoint for use in opentelemetry-instrument #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <[email protected]>
dosubot
bot
added
the
size:L
|
crewai-latest fail seems unrelated, but I'll look into it |
|
@nate-mar appreciate if you could fix crew-ai-latest. I think crewai-tools needs to be bumped when that's running, which also ends up with a newer version of openai, that seems to either drift the recordings or hit this in litellm. I ran out of time and I'm not going to be available a while from monday (though I will be tomorrow sunday UTC+8 morning). If I happen to be away and this becomes ready, feel free to push commits or rebase this without my permission. ciao! |
|
No problem! I’m pretty sure I already know what the issue is with
crewai-latest. I’ll take care of it. Appreciate all the work you’ve done on
this!!
…On Sat, Feb 8, 2025 at 12:12 AM Adrian Cole ***@***.***> wrote:
@nate-mar <https://github.com/nate-mar> appreciate if you could fix
crew-ai-latest. I think crewai-tools needs to be bumped when that's
running, which also ends up with a newer version of openai, that seems to
either drift the recordings or hit this in litellm
<BerriAI/litellm#8083>. I ran out of time and I'm
not going to be available a while from monday (though I will be tomorrow
sunday UTC+8 morning). If I happen to be away and this becomes ready, feel
free to push commits or rebase this without my permission.
ciao!
—
Reply to this email directly, view it on GitHub
<#1278 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQGHRZHCLWZ7DDWFPV6JLED2OW37ZAVCNFSM6AAAAABWXNHYP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBUG4YTMMBQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
nate-mar
approved these changes
Feb 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openinference can become automatically enabled with opentelemetry's zero code approach for python, by adding entrypoints into the pyproject.toml.
Specifically, after this, as long as you have the dependencies of your main code, plus openinference-instrumentation-XXXX, and env exported with standard variables, if you launch with
opentelemetry-instrument, traces will magically appear.I've added this configuration for all instrumentation, similar to smolagents done in #1276. I've also added a unit test as that helps ensure refactorings won't break this later.