-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prompts): tool call definitions #5922
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axiomofjoy
force-pushed
the
xander/pydantic-tool-models
branch
from
January 7, 2025 21:45
92b75cf
to
ef99e64
Compare
axiomofjoy
changed the title
feat(prompts): server-side validation of openai tool call definitions
feat(prompts): openai tool call definitions
Jan 7, 2025
dosubot
bot
added
the
size:XL
This PR changes 500-999 lines, ignoring generated files.
label
Jan 7, 2025
axiomofjoy
force-pushed
the
xander/pydantic-tool-models
branch
from
January 7, 2025 22:40
ef99e64
to
bcd2c84
Compare
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
and removed
size:XL
This PR changes 500-999 lines, ignoring generated files.
labels
Jan 8, 2025
axiomofjoy
changed the title
feat(prompts): openai tool call definitions
feat(prompts): tool call definitions
Jan 8, 2025
cephalization
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. Thanks for calling out the UI schema drift too!
Merging for now, will continue iterating. |
mikeldking
pushed a commit
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pydantic types for OpenAI and Anthropic tool call definitions and corresponding tests.
resolves #5887