Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prompts): tool call definitions #5922

Merged
merged 15 commits into from
Jan 9, 2025
Merged

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Jan 7, 2025

Adds pydantic types for OpenAI and Anthropic tool call definitions and corresponding tests.

resolves #5887

@axiomofjoy axiomofjoy changed the base branch from main to prompts January 7, 2025 08:53
@axiomofjoy axiomofjoy force-pushed the xander/pydantic-tool-models branch from 92b75cf to ef99e64 Compare January 7, 2025 21:45
@axiomofjoy axiomofjoy changed the title feat(prompts): server-side validation of openai tool call definitions feat(prompts): openai tool call definitions Jan 7, 2025
@axiomofjoy axiomofjoy marked this pull request as ready for review January 7, 2025 21:46
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 7, 2025
@axiomofjoy axiomofjoy force-pushed the xander/pydantic-tool-models branch from ef99e64 to bcd2c84 Compare January 7, 2025 22:40
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jan 8, 2025
@axiomofjoy axiomofjoy changed the title feat(prompts): openai tool call definitions feat(prompts): tool call definitions Jan 8, 2025
Copy link
Contributor

@cephalization cephalization left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Thanks for calling out the UI schema drift too!

@axiomofjoy
Copy link
Contributor Author

Merging for now, will continue iterating.

@axiomofjoy axiomofjoy merged commit ef5ce56 into prompts Jan 9, 2025
48 checks passed
@axiomofjoy axiomofjoy deleted the xander/pydantic-tool-models branch January 9, 2025 19:18
mikeldking pushed a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[hub] server-side validation of tool definitions via pydantic types
2 participants