Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prompts): display author, tags, etc. in version list #6097

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

mikeldking
Copy link
Contributor

resolves #6075

Screenshot 2025-01-16 at 5 29 47 PM Screenshot 2025-01-16 at 5 29 05 PM

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 17, 2025
import { graphql, useFragment } from "react-relay";

import { Tag, TagGroup, TagList } from "@phoenix/components";
import { Label } from "@arizeai/components";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phoenix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still need to migrate

</li>
);
})}
</ul>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put some kind of element here when version number is not 1 but we're at the last index?

Something to cap the line but signify more items.

Or we can maybe reduce the opacity of the last line when there are more to load

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-16 at 9 57 05 PM

@mikeldking mikeldking merged commit 5b26835 into prompts Jan 17, 2025
6 checks passed
@mikeldking mikeldking deleted the mikeldking/6075-disclosure-styles branch January 17, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants