-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add prompt verions REST route /prompts/{id}/versions
#6098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anticorrelator
commented
Jan 17, 2025
- Lists all versions for a specific prompt
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Jan 17, 2025
I get errors on
|
anticorrelator
force-pushed
the
dustin/add-prompts-versions-listing
branch
from
January 22, 2025 05:04
02d6ab3
to
6776c13
Compare
@cephalization whoops! fixed, thank you |
Hmm something about the name validation is unhappy
I've tried wiping my db and a few names like This crops up on fetching all prompts or a prompt version. Maybe we need a rebase? |
cephalization
approved these changes
Jan 23, 2025
* wip * WIP * WIP * add the prompt type * add initial listing * feat: temporary prompt * final changes * add aria role
anticorrelator
force-pushed
the
dustin/add-prompts-versions-listing
branch
from
January 28, 2025 17:08
fd9cb5d
to
1562974
Compare
mikeldking
added a commit
that referenced
this pull request
Feb 6, 2025
* feat(promts): skeleton UI for promts (#5726) * wip * WIP * WIP * add the prompt type * add initial listing * feat: temporary prompt * final changes * add aria role * Build OpenAPI schema * Use GID, not databse ID * Build openapi schema * Refactor to use prompt identifier * Update OpenAPI schema * Ruff 🐶 * Update route and openapi schema * Use new pydantic models * Restore latest route * Rebuild schema * Add warning (we're not handling citation events) * Temporarily ignore `assert_never` * Remove react component * Remove component * Ruff 🐶 --------- Co-authored-by: Mikyo King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.