Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tab navigation to single tile component #6

Merged
merged 3 commits into from
Oct 8, 2021

Conversation

alfonsobries
Copy link
Member

@alfonsobries alfonsobries commented Oct 1, 2021

Summary

To test:

  • merge this on msq
  • recompile assets
  • you should be able to navigate to the category tiles with the keyboard
  • press space to select an option
  • in case you wonder, the enter key doesn't do anything, and you cannot deselect by pressing space two times (same behavior that a native checkbox have)

image

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I provided a screenshot of my changes to the component (if applicable)
  • I regenerated the icons.html file and checked if my newly added icon is shown correctly (if necessary)
  • I added an explanation on how to use the component to the readme (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alfonsobries alfonsobries marked this pull request as draft October 1, 2021 18:17
@ItsANameToo ItsANameToo marked this pull request as ready for review October 8, 2021 11:51
@ItsANameToo ItsANameToo merged commit 3bf6705 into main Oct 8, 2021
@ItsANameToo ItsANameToo deleted the refactor/tile-element-tab branch October 8, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants