fix: add null check before validating password (#102)

ArkEcosystemArchive · Mar 24, 2021 · 9fb6752 · 9fb6752
1 parent d725042
commit 9fb6752
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/src/Components/Concerns/ValidatesPassword.php b/src/Components/Concerns/ValidatesPassword.php
@@ -18,6 +18,10 @@ trait ValidatesPassword
 
     public function updatedStatePassword($password)
     {
+        if (is_null($password)) {
+            return;
+        }
+
         $this->errorMessages = [];
 
         $passwordValidator = (new Password())

diff --git a/tests/Components/UpdatePasswordFormTest.php b/tests/Components/UpdatePasswordFormTest.php
@@ -50,3 +50,27 @@
             'needsMinimumLength'    => false,
         ]);
 });
+
+it('handles password being null', function () {
+    $user = createUserModel();
+
+    Livewire::actingAs($user)
+        ->test(UpdatePasswordForm::class)
+        ->assertSet('state', [
+            'current_password'      => '',
+            'password'              => '',
+            'password_confirmation' => '',
+        ])
+        ->assertViewIs('ark-fortify::profile.update-password-form')
+        ->set('state.current_password', 'password')
+        ->set('state.password', null)
+        ->set('state.password_confirmation', null)
+        ->call('updatePassword')
+        ->assertSet('passwordRules', [
+            'needsLowercase'        => false,
+            'needsUppercase'        => false,
+            'needsNumeric'          => false,
+            'needsSpecialCharacter' => false,
+            'needsMinimumLength'    => false,
+        ]);
+});