Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ark Minimun_gasFee Fix #251

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Conversation

DanielEmmanuel1
Copy link
Contributor

Implement Minimum Gas Validation and Message Cancellation with Unit Testing

Description

This PR fixes the lack of a minimum gas amount when making a cross-chain bridge by specifying a minimum value, which can be adjusted by the contract owner (team) as the gas situation changes.

Related Issue

Resolves issue #231

Changes Made

  • Added custom error for minimum gas fee validation.
  • Specified a minimum gas fee for bridging, adjustable by the contract owner as the gas situation evolves.
  • Added a function to update the minimum gas and a function to get the current minimum gas.
  • Emitted the MinimumGasFeeUpdated event upon changes.
  • Added unit tests for the minimum gas requirement.
  • Added unit tests for updating the minimum gas.

Impact

This change does not introduce any breaking changes but improves the user experience (UX) of the bridge. It protects users from sending messages with insufficient fees.

Testing

  • Added new unit tests for minimum gas fee validation.
  • Added unit tests for updating the minimum gas amount.
  • All tests are passing successfully.

Screenshot

new

Copy link

vercel bot commented Oct 3, 2024

@DanielEmmanuel1 is attempting to deploy a commit to the Screenshot Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@ptisserand ptisserand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution.
Good to be merged

@ptisserand ptisserand added this pull request to the merge queue Oct 4, 2024
Merged via the queue into ArkProjectNFTs:main with commit 229d3dc Oct 4, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants