Adding Direct Vehicle Move waypoint #11

CommandDDOS · 2024-08-14T21:39:07Z

New Waypoint Vehicle Direct Move
Waypoint force vehicle drivers to move directly to waypoint position by setDriveOnPath
Waypoint create new groups for each driver in original group and assign them waypoint for better ability to control in zeus.

addons/waypoint/XEH_PREP.hpp

Co-authored-by: 3Mydlo3 <[email protected]>

addons/waypoint/CfgWaypoints.cfg

veteran29 · 2024-09-12T23:04:37Z

addons/waypoint/CfgWaypoints.cfg

+        class Move_vehicle {
+            displayName = CSTRING(Vehicle_Move_Name);


Vehicle Move or Move Vehicle, stringtable naming is inconsistent with class. Also use ~~camel~~pascal case for this (VehicleMove or MoveVehicle)

Actually VehicleMove or MoveVehicle would be PascalCase, not camelCase.

addons/waypoint/XEH_postInit.sqf

addons/waypoint/XEH_preInit.sqf

veteran29 · 2024-09-12T23:08:27Z

addons/waypoint/functions/fnc_moveVehicleWp.sqf

+ * Return Value:
+ * none
+ *
+*/


Comment does not follow the template, excess line between author and arguments.

veteran29 · 2024-09-12T23:32:25Z

addons/waypoint/functions/fnc_moveVehicleWp.sqf

+                        (driver _vehicle) disableAI "Path";
+                        (driver _vehicle) enableAI "Path";


What does this achieve? Does this reset pathfinding?

Trying reset driver mostly in situationn where driver move vehicle super slowly after hitting object or moving super slowly in turning to waypoint

addons/waypoint/functions/fnc_moveVehicleWp.sqf

veteran29 · 2024-09-12T23:33:42Z

addons/waypoint/functions/fnc_moveVehicleWp.sqf

+        _driver setVariable ["lambs_danger_disableAI", true];
+        (group _driver) setVariable ["lambs_danger_disablegroupAI", true];


You should save and restore values of these variables after the waypoint is completed.

addons/waypoint/functions/fnc_moveVehicleWp.sqf

3Mydlo3 · 2024-09-12T23:43:23Z

addons/waypoint/script_component.hpp

@@ -0,0 +1,15 @@
+#define COMPONENT waypoint


Personally I think plural would be more in-place for component concerning (possibly) multiple waypoints.

Suggested change

#define COMPONENT waypoint

#define COMPONENT waypoints

Keep in mind renaming folder.

I agree, do not forget to change pboprefix and folder names too.

3Mydlo3 · 2024-09-12T23:47:52Z

addons/waypoint/functions/fnc_moveVehicleWp.sqf

+
+if !(local _group) exitwith {false};
+
+//vehicle list


Unnecessary comment, it's obvious what _vehicles = []; means.

Suggested change

//vehicle list

addons/waypoint/functions/fnc_moveVehicleWp.sqf

3Mydlo3 · 2024-09-13T00:03:01Z

addons/waypoint/README.md

+## Waypoint
+
+Waypoints:
+- Vehicle Move - Order vehicle to move in strain line to target ignoring AI orders and situation. waypoint create pool of vehicles where group units are driver and create new group per vehicle


You should keep one empty line before and after any list in Markdown. Plus some spelling fixes.

I'm not sure what that does mean, so if my suggestion doesn't apply, please fix that.

Waypoint creates pool of vehicles where group units are driver and create new group per vehicle

Suggested change

## Waypoint

Waypoints:

- Vehicle Move - Order vehicle to move in strain line to target ignoring AI orders and situation. waypoint create pool of vehicles where group units are driver and create new group per vehicle

## Waypoints

New Waypoints:

- Vehicle Move - Orders vehicles to move in straight line to the waypoint position, ignoring AI orders and situation. Splits the original group to one group per vehicle for the duration of the move.

fast fixes from review Co-authored-by: Filip Maciejewski <[email protected]>

3Mydlo3 · 2024-09-13T00:23:03Z

addons/waypoint/functions/fnc_moveVehicleWp.sqf

+            private _point1 = _vehicle getrelpos [2,0];
+            private _point2 = _vehicle getrelpos [3,0];


Please review your whole code for such cases, there's plenty of them. Please stick to camelCase/the same casing as on Biki.

Suggested change

private _point1 = _vehicle getrelpos [2,0];

private _point2 = _vehicle getrelpos [3,0];

private _point1 = _vehicle getRelPos [2,0];

private _point2 = _vehicle getRelPos [3,0];

3Mydlo3 · 2024-09-13T00:26:02Z

addons/waypoint/functions/fnc_moveVehicleWp.sqf

+        [{
+        //condition
+            params ["_vehicle","_group"];
+            if !(waypointScript [_group,currentWaypoint _group] == QPATHTOF(functions\fnc_moveVehicleWP.sqf)) exitwith {true};


What if next waypoint is the same? Will there be 2 competing scripts? I don't see a valid reason for checking waypointScript. The only thing that should matter is active waypoint number (you could pass it as an argument to WUAE to have the old value for comparison).

but waypoint gonna end only when WUAE is complete, so new wuae gonna be created for next waypoint
and this is to complete WUAE after ZEUS change Waypointype
edit. In arma 2.18 gonna be a option to replace it by passing _ThisScript to WUAE

Relevant FT ticket: https://feedback.bistudio.com/T183544

Nice, can be resolved then.

3Mydlo3 · 2024-09-13T00:34:21Z

A general comment from me would be to rethink how your waypoint function is composed.

There's a separate logic for splitting group to one per vehicle before actual logic related to making vehicle move from point to point. Consider extracting one logic or the other to separate function.
Your WUAE condition is enormous, checks many things and it's not clear what's the purpose of all that logic there. Could be moved to a separate function and cleaned up a bit. Possibly split into smaller parts as wait time handling seems to be very different part of the condition than first few ifs.
If you're extracting functions (which I think would benefit readability of the code), consider renaming fnc_moveVehicleWp to fnc_waypointMoveVehicle to keep it in line with ZEN's scripted waypoints. As a bonus, all functions attached to waypoints will have waypoint prefix that will allow them to be distinguished from other utility functions (like your extracted conditions or splitting group per vehicle logic).

3Mydlo3 · 2024-09-13T00:36:12Z

addons/waypoint/functions/fnc_moveVehicleWp.sqf

+                _vehicle setvariable [QGVAR(ActiveVehicleMove),false];
+            },[_vehicle],0.2] call cba_fnc_waitAndExecute;


Please keep a space after ,. Also multiple occurrences.

Suggested change

_vehicle setvariable [QGVAR(ActiveVehicleMove),false];

},[_vehicle],0.2] call cba_fnc_waitAndExecute;

_vehicle setvariable [QGVAR(ActiveVehicleMove), false];

}, [_vehicle], 0.2] call cba_fnc_waitAndExecute;

I see veteran spared his time writing such comments and will have you fix all the issues that will be automatically reported by updated HEMTT. 🤣

veteran29 · 2024-09-13T00:44:01Z

@CommandDDOS please switch to HEMTT 1.3, I've merged master to your PR branch.

Ininitial

2faccd2

CommandDDOS added the feature New feature or request label Aug 14, 2024

CommandDDOS requested a review from a team as a code owner August 14, 2024 21:39

CommandDDOS requested review from 3Mydlo3 and removed request for a team August 14, 2024 21:39

3Mydlo3 reviewed Aug 14, 2024

View reviewed changes

addons/waypoint/XEH_PREP.hpp Outdated Show resolved Hide resolved

3Mydlo3 requested a review from veteran29 August 14, 2024 22:34

CommandDDOS and others added 3 commits August 15, 2024 00:43

Update addons/waypoint/XEH_PREP.hpp

3486c18

Co-authored-by: 3Mydlo3 <[email protected]>

delete tab in code

649e0ca

clearing empty lines and fix name in readme

59b185e

veteran29 requested changes Sep 12, 2024

View reviewed changes

3Mydlo3 reviewed Sep 12, 2024

View reviewed changes

addons/waypoint/functions/fnc_moveVehicleWp.sqf Outdated Show resolved Hide resolved

3Mydlo3 reviewed Sep 12, 2024

View reviewed changes

addons/waypoint/functions/fnc_moveVehicleWp.sqf Outdated Show resolved Hide resolved

3Mydlo3 reviewed Sep 13, 2024

View reviewed changes

Apply suggestions from code review

d98bcda

fast fixes from review Co-authored-by: Filip Maciejewski <[email protected]>

3Mydlo3 reviewed Sep 13, 2024

View reviewed changes

Merge remote-tracking branch 'origin/master' into Waypoint

376c288

veteran29 self-requested a review September 13, 2024 00:44

CommandDDOS added 5 commits September 13, 2024 22:10

waypoint logic simplified, added forgotten files, fixed configs.

73174e6

delete left tab

f57b917

deleting not needed ";"

20cd57d

rewrite

de610a6

fix command size name

1cdccc0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Direct Vehicle Move waypoint #11

Adding Direct Vehicle Move waypoint #11

CommandDDOS commented Aug 14, 2024

veteran29 Sep 12, 2024 •

edited

Loading

3Mydlo3 Sep 12, 2024 •

edited

Loading

veteran29 Sep 12, 2024

veteran29 Sep 12, 2024

CommandDDOS Sep 12, 2024

veteran29 Sep 12, 2024

3Mydlo3 Sep 12, 2024 •

edited

Loading

veteran29 Sep 12, 2024

3Mydlo3 Sep 12, 2024

3Mydlo3 Sep 13, 2024

3Mydlo3 Sep 13, 2024

3Mydlo3 Sep 13, 2024

CommandDDOS Sep 13, 2024 •

edited

Loading

veteran29 Sep 13, 2024

3Mydlo3 Sep 13, 2024

3Mydlo3 commented Sep 13, 2024

3Mydlo3 Sep 13, 2024

3Mydlo3 Sep 13, 2024

veteran29 commented Sep 13, 2024

		class Move_vehicle {
		displayName = CSTRING(Vehicle_Move_Name);

		(driver _vehicle) disableAI "Path";
		(driver _vehicle) enableAI "Path";

		_driver setVariable ["lambs_danger_disableAI", true];
		(group _driver) setVariable ["lambs_danger_disablegroupAI", true];

		private _point1 = _vehicle getrelpos [2,0];
		private _point2 = _vehicle getrelpos [3,0];

		_vehicle setvariable [QGVAR(ActiveVehicleMove),false];
		},[_vehicle],0.2] call cba_fnc_waitAndExecute;

Adding Direct Vehicle Move waypoint #11

Are you sure you want to change the base?

Adding Direct Vehicle Move waypoint #11

Conversation

CommandDDOS commented Aug 14, 2024

veteran29 Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

3Mydlo3 Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

3Mydlo3 Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CommandDDOS Sep 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

3Mydlo3 commented Sep 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

veteran29 commented Sep 13, 2024

veteran29 Sep 12, 2024 •

edited

Loading

3Mydlo3 Sep 12, 2024 •

edited

Loading

3Mydlo3 Sep 12, 2024 •

edited

Loading

CommandDDOS Sep 13, 2024 •

edited

Loading