Change access modifiers to private (#323)

ArmaForces · Jan 15, 2024 · 686e545 · 686e545
2 parents c3e4e0a + 1d0e1d9
commit 686e545
Show file tree

Hide file tree

Showing 13 changed files with 40 additions and 40 deletions.
diff --git a/src/Api/Input/Attendance/AttendanceInput.php b/src/Api/Input/Attendance/AttendanceInput.php
@@ -13,11 +13,11 @@ class AttendanceInput
 {
     #[Assert\NotBlank]
     #[Assert\Length(max: 255)]
-    protected ?string $missionId = null;
+    private ?string $missionId = null;
 
     #[Assert\NotBlank]
     #[SteamProfileId]
-    protected ?int $playerId = null;
+    private ?int $playerId = null;
 
     public function getMissionId(): ?string
     {

diff --git a/src/Api/Output/Attendance/AttendanceOutput.php b/src/Api/Output/Attendance/AttendanceOutput.php
@@ -6,10 +6,10 @@
 
 class AttendanceOutput
 {
-    protected ?string $id = null;
-    protected ?\DateTimeInterface $createdAt = null;
-    protected ?string $missionId = null;
-    protected ?int $playerId = null;
+    private ?string $id = null;
+    private ?\DateTimeInterface $createdAt = null;
+    private ?string $missionId = null;
+    private ?int $playerId = null;
 
     public function getId(): ?string
     {

diff --git a/src/Api/Output/Dlc/DlcOutput.php b/src/Api/Output/Dlc/DlcOutput.php
@@ -6,12 +6,12 @@
 
 class DlcOutput
 {
-    protected ?string $id = null;
-    protected ?string $name = null;
-    protected ?\DateTimeInterface $createdAt = null;
-    protected ?\DateTimeInterface $lastUpdatedAt = null;
-    protected ?int $appId = null;
-    protected ?string $directory = null;
+    private ?string $id = null;
+    private ?string $name = null;
+    private ?\DateTimeInterface $createdAt = null;
+    private ?\DateTimeInterface $lastUpdatedAt = null;
+    private ?int $appId = null;
+    private ?string $directory = null;
 
     public function getId(): ?string
     {

diff --git a/src/Api/Output/Mod/ModOutput.php b/src/Api/Output/Mod/ModOutput.php
@@ -6,15 +6,15 @@
 
 class ModOutput
 {
-    protected ?string $id = null;
-    protected ?string $name = null;
-    protected ?\DateTimeInterface $createdAt = null;
-    protected ?\DateTimeInterface $lastUpdatedAt = null;
-    protected ?string $source = null;
-    protected ?string $status = null;
-    protected ?string $type = null;
-    protected ?int $itemId = null;
-    protected ?string $directory = null;
+    private ?string $id = null;
+    private ?string $name = null;
+    private ?\DateTimeInterface $createdAt = null;
+    private ?\DateTimeInterface $lastUpdatedAt = null;
+    private ?string $source = null;
+    private ?string $status = null;
+    private ?string $type = null;
+    private ?int $itemId = null;
+    private ?string $directory = null;
 
     public function getId(): ?string
     {

diff --git a/src/Api/Output/ModList/ModListDetailsOutput.php b/src/Api/Output/ModList/ModListDetailsOutput.php
@@ -9,8 +9,8 @@
 
 class ModListDetailsOutput extends ModListOutput
 {
-    protected array $mods = [];
-    protected array $dlcs = [];
+    private array $mods = [];
+    private array $dlcs = [];
 
     /**
      * @return ModOutput[]

diff --git a/src/Api/Output/ModList/ModListOutput.php b/src/Api/Output/ModList/ModListOutput.php
@@ -6,12 +6,12 @@
 
 class ModListOutput
 {
-    protected ?string $id = null;
-    protected ?string $name = null;
-    protected bool $active;
-    protected bool $approved;
-    protected ?\DateTimeInterface $createdAt = null;
-    protected ?\DateTimeInterface $lastUpdatedAt = null;
+    private ?string $id = null;
+    private ?string $name = null;
+    private bool $active;
+    private bool $approved;
+    private ?\DateTimeInterface $createdAt = null;
+    private ?\DateTimeInterface $lastUpdatedAt = null;
 
     public function getId(): ?string
     {

diff --git a/src/Entity/UserGroup/UserGroup.php b/src/Entity/UserGroup/UserGroup.php
@@ -13,7 +13,7 @@
 
 class UserGroup extends AbstractBlamableEntity
 {
-    protected Collection $users;
+    private Collection $users;
     private string $name;
     private ?string $description;
     private UserGroupPermissions $permissions;

diff --git a/src/Repository/Mod/ModRepository.php b/src/Repository/Mod/ModRepository.php
@@ -108,7 +108,7 @@ public function findIncludedRequiredSteamWorkshopMods(ModList $modList): array
         return $qb->getQuery()->getResult();
     }
 
-    protected function applyIncludedModsFilter(QueryBuilder $queryBuilder, ModList $modList): void
+    private function applyIncludedModsFilter(QueryBuilder $queryBuilder, ModList $modList): void
     {
         $expr = $queryBuilder->expr();
 

diff --git a/src/Security/Authenticator/DiscordAuthenticator.php b/src/Security/Authenticator/DiscordAuthenticator.php
@@ -39,12 +39,12 @@
  */
 class DiscordAuthenticator extends OAuth2Authenticator implements AuthenticationEntryPointInterface
 {
-    protected const DISCORD_CLIENT_NAME = 'discord_main';
+    private const DISCORD_CLIENT_NAME = 'discord_main';
 
-    protected const HOME_INDEX_PAGE_ROUTE_NAME = 'app_home_index';
-    protected const HOME_JOIN_US_PAGE_ROUTE_NAME = 'app_home_join_us';
-    protected const LOGIN_PAGE_ROUTE_NAME = 'app_security_connect_discord';
-    protected const SUPPORTED_ROUTE_NAME = 'app_security_connect_discord_check';
+    private const HOME_INDEX_PAGE_ROUTE_NAME = 'app_home_index';
+    private const HOME_JOIN_US_PAGE_ROUTE_NAME = 'app_home_join_us';
+    private const LOGIN_PAGE_ROUTE_NAME = 'app_security_connect_discord';
+    private const SUPPORTED_ROUTE_NAME = 'app_security_connect_discord_check';
 
     public function __construct(
         private ClientRegistry $clientRegistry,

diff --git a/src/Twig/CalendarExtension.php b/src/Twig/CalendarExtension.php
@@ -29,7 +29,7 @@ public function createMissionIcalLink(MissionDto $mission): string
         return $this->createMissionEventLink($mission)->ics();
     }
 
-    protected function createMissionEventLink(MissionDto $mission): Link
+    private function createMissionEventLink(MissionDto $mission): Link
     {
         $fromDate = \DateTime::createFromImmutable($mission->getDate())->sub(new \DateInterval('PT30M'));
         $toDate = \DateTime::createFromImmutable($mission->getDate())->add(new \DateInterval('PT2H'));

diff --git a/src/Twig/ImgproxyExtension.php b/src/Twig/ImgproxyExtension.php
@@ -47,7 +47,7 @@ public function getProxyImageUrl(string $url, int $width = 0, int $height = 250,
     /**
      * https://github.com/imgproxy/imgproxy/blob/master/examples/signature.php.
      */
-    protected function getSignature(string $path): string
+    private function getSignature(string $path): string
     {
         $binaryKey = pack('H*', $this->proxyKey);
         if (empty($binaryKey)) {

diff --git a/src/Validator/Dlc/SteamStoreArma3DlcUrlValidator.php b/src/Validator/Dlc/SteamStoreArma3DlcUrlValidator.php
@@ -16,7 +16,7 @@
 
 class SteamStoreArma3DlcUrlValidator extends AbstractValidator
 {
-    protected const ARMA_3_GAME_ID = 107410;
+    private const ARMA_3_GAME_ID = 107410;
 
     public function __construct(
         EntityManagerInterface $entityManager,

diff --git a/src/Validator/Mod/SteamWorkshopArma3ModUrlValidator.php b/src/Validator/Mod/SteamWorkshopArma3ModUrlValidator.php
@@ -16,7 +16,7 @@
 
 class SteamWorkshopArma3ModUrlValidator extends AbstractValidator
 {
-    protected const ARMA_3_GAME_ID = 107410;
+    private const ARMA_3_GAME_ID = 107410;
 
     public function __construct(
         EntityManagerInterface $entityManager,