Make translation messages consistent with Symfony validators (#317)

This will: - title
ArmaForces · Jan 8, 2024 · a267ad5 · a267ad5
2 parents 93700a6 + 78d0f87
commit a267ad5
Show file tree

Hide file tree

Showing 15 changed files with 36 additions and 36 deletions.
diff --git a/src/Validator/Attendance/UniqueAttendance.php b/src/Validator/Attendance/UniqueAttendance.php
@@ -9,7 +9,7 @@
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::IS_REPEATABLE)]
 class UniqueAttendance extends Constraint
 {
-    public string $message = 'Attendance of player "{{ playerId }}" in mission "{{ missionId }}" already exists';
+    public string $message = 'Attendance of player "{{ playerId }}" in mission "{{ missionId }}" already exists.';
     public ?string $errorPath = null;
 
     public function __construct(

diff --git a/src/Validator/Dlc/SteamStoreArma3DlcUrl.php b/src/Validator/Dlc/SteamStoreArma3DlcUrl.php
@@ -9,9 +9,9 @@
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::IS_REPEATABLE)]
 class SteamStoreArma3DlcUrl extends Constraint
 {
-    public string $invalidDlcUrlMessage = 'Invalid Steam Store DLC url';
-    public string $dlcNotFoundMessage = 'DLC not found';
-    public string $notAnArma3DlcMessage = 'Url is not an Arma 3 DLC';
+    public string $invalidDlcUrlMessage = 'Invalid Steam Store DLC url.';
+    public string $dlcNotFoundMessage = 'DLC not found.';
+    public string $notAnArma3DlcMessage = 'Url is not an Arma 3 DLC.';
     public ?string $errorPath = null;
 
     public function __construct(

diff --git a/src/Validator/Dlc/UniqueDirectoryDlc.php b/src/Validator/Dlc/UniqueDirectoryDlc.php
@@ -9,7 +9,7 @@
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::IS_REPEATABLE)]
 class UniqueDirectoryDlc extends Constraint
 {
-    public string $message = 'DLC associated with directory "{{ directoryName }}" already exist';
+    public string $message = 'DLC associated with directory "{{ directoryName }}" already exist.';
     public ?string $errorPath = null;
 
     public function __construct(

diff --git a/src/Validator/Dlc/UniqueSteamStoreDlc.php b/src/Validator/Dlc/UniqueSteamStoreDlc.php
@@ -9,7 +9,7 @@
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::IS_REPEATABLE)]
 class UniqueSteamStoreDlc extends Constraint
 {
-    public string $message = 'DLC associated with url "{{ dlcUrl }}" already exist';
+    public string $message = 'DLC associated with url "{{ dlcUrl }}" already exist.';
     public ?string $errorPath = null;
 
     public function __construct(

diff --git a/src/Validator/Mod/SteamWorkshopArma3ModUrl.php b/src/Validator/Mod/SteamWorkshopArma3ModUrl.php
@@ -9,10 +9,10 @@
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::IS_REPEATABLE)]
 class SteamWorkshopArma3ModUrl extends Constraint
 {
-    public string $invalidModUrlMessage = 'Invalid Steam Workshop mod url';
-    public string $modNotFoundMessage = 'Mod not found';
-    public string $notAnArma3ModMessage = 'Url is not an Arma 3 mod';
-    public string $modIsPrivateOrMissingDetails = 'Mod is either private or missing required details';
+    public string $invalidModUrlMessage = 'Invalid Steam Workshop mod url.';
+    public string $modNotFoundMessage = 'Mod not found.';
+    public string $notAnArma3ModMessage = 'Url is not an Arma 3 mod.';
+    public string $modIsPrivateOrMissingDetails = 'Mod is either private or missing required details.';
     public ?string $errorPath = null;
     public ?string $nameErrorPath = null;
 

diff --git a/src/Validator/Mod/UniqueDirectoryMod.php b/src/Validator/Mod/UniqueDirectoryMod.php
@@ -9,7 +9,7 @@
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::IS_REPEATABLE)]
 class UniqueDirectoryMod extends Constraint
 {
-    public string $message = 'Mod associated with directory "{{ directoryName }}" already exist';
+    public string $message = 'Mod associated with directory "{{ directoryName }}" already exist.';
     public ?string $errorPath = null;
 
     public function __construct(

diff --git a/src/Validator/Mod/UniqueSteamWorkshopMod.php b/src/Validator/Mod/UniqueSteamWorkshopMod.php
@@ -9,7 +9,7 @@
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::IS_REPEATABLE)]
 class UniqueSteamWorkshopMod extends Constraint
 {
-    public string $message = 'Mod associated with url "{{ modUrl }}" already exist';
+    public string $message = 'Mod associated with url "{{ modUrl }}" already exist.';
     public ?string $errorPath = null;
 
     public function __construct(

diff --git a/src/Validator/ModGroup/UniqueModGroupName.php b/src/Validator/ModGroup/UniqueModGroupName.php
@@ -9,7 +9,7 @@
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::IS_REPEATABLE)]
 class UniqueModGroupName extends Constraint
 {
-    public string $message = 'Mod group with the same name "{{ modGroupName }}" already exist';
+    public string $message = 'Mod group with the same name "{{ modGroupName }}" already exist.';
     public ?string $errorPath = null;
 
     public function __construct(

diff --git a/src/Validator/ModList/UniqueModListName.php b/src/Validator/ModList/UniqueModListName.php
@@ -9,7 +9,7 @@
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::IS_REPEATABLE)]
 class UniqueModListName extends Constraint
 {
-    public string $message = 'Mod list with the same name "{{ modListName }}" already exist';
+    public string $message = 'Mod list with the same name "{{ modListName }}" already exist.';
     public ?string $errorPath = null;
 
     public function __construct(

diff --git a/src/Validator/SteamProfileId.php b/src/Validator/SteamProfileId.php
@@ -10,7 +10,7 @@
 class SteamProfileId extends Regex
 {
     /** @var string */
-    public $message = 'Invalid Steam profile ID';
+    public $message = 'Invalid Steam profile ID.';
 
     /** @var string */
     public $pattern = '~^\d{17}$~';

diff --git a/src/Validator/User/UniqueUserSteamId.php b/src/Validator/User/UniqueUserSteamId.php
@@ -9,7 +9,7 @@
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::IS_REPEATABLE)]
 class UniqueUserSteamId extends Constraint
 {
-    public string $message = 'User with the same Steam ID "{{ userSteamId }}" already exist';
+    public string $message = 'User with the same Steam ID "{{ userSteamId }}" already exist.';
     public ?string $errorPath = null;
 
     public function __construct(

diff --git a/src/Validator/UserGroup/UniqueUserGroupName.php b/src/Validator/UserGroup/UniqueUserGroupName.php
@@ -9,7 +9,7 @@
 #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::IS_REPEATABLE)]
 class UniqueUserGroupName extends Constraint
 {
-    public string $message = 'User group with the same name "{{ userGroupName }}" already exist';
+    public string $message = 'User group with the same name "{{ userGroupName }}" already exist.';
     public ?string $errorPath = null;
 
     public function __construct(

diff --git a/src/Validator/WindowsDirectoryName.php b/src/Validator/WindowsDirectoryName.php
@@ -10,7 +10,7 @@
 class WindowsDirectoryName extends Regex
 {
     /** @var string */
-    public $message = 'Invalid directory name';
+    public $message = 'Invalid directory name.';
 
     /** @var string */
     public $pattern = '/^.[^\<\>\:\"\/\|\?\*]{1,248}$/ui';

diff --git a/tests/functional/Api/Controller/Attendance/CreateAttendanceActionTest.php b/tests/functional/Api/Controller/Attendance/CreateAttendanceActionTest.php
@@ -84,7 +84,7 @@ public function createAttendanceAction_duplicatedEntry_returnsUnprocessableEntit
 
         $this::assertResponseStatusCodeSame(Response::HTTP_UNPROCESSABLE_ENTITY);
         $this::assertJsonContains([
-            'detail' => 'Attendance of player "76561198048200529" in mission "mission_1" already exists',
+            'detail' => 'Attendance of player "76561198048200529" in mission "mission_1" already exists.',
         ]);
     }
 }
diff --git a/translations/validators.pl.yaml b/translations/validators.pl.yaml
@@ -1,40 +1,40 @@
 # Unique User Steam Id Validator
-User with the same Steam ID "{{ userSteamId }}" already exist: Użytkownik o Steam ID "{{ userSteamId }}" już istnieje
+User with the same Steam ID "{{ userSteamId }}" already exist.: Użytkownik o Steam ID "{{ userSteamId }}" już istnieje.
 
 # Steam Profile Id Validator
-Invalid Steam profile ID: Błędne ID profilu Steam
+Invalid Steam profile ID.: Błędne ID profilu Steam
 
 # Unique Steam Workshop Mod Validator
-Mod associated with url "{{ modUrl }}" already exist: Mod znajdujący się pod adresem "{{ modUrl }}" już istnieje
+Mod associated with url "{{ modUrl }}" already exist.: Mod znajdujący się pod adresem "{{ modUrl }}" już istnieje.
 
 # Unique Steam Store Dlc Validator
-DLC associated with url "{{ dlcUrl }}" already exist: DLC znajdujący się pod adresem "{{ dlcUrl }}" już istnieje
+DLC associated with url "{{ dlcUrl }}" already exist.: DLC znajdujący się pod adresem "{{ dlcUrl }}" już istnieje.
 
 # Unique Directory Mod Validator
-Mod associated with directory "{{ directoryName }}" already exist: Mod znajdujący się w katalogu "{{ directoryName }}" już istnieje
+Mod associated with directory "{{ directoryName }}" already exist.: Mod znajdujący się w katalogu "{{ directoryName }}" już istnieje.
 
 # Unique Directory Dlc Validator
-DLC associated with directory "{{ directoryName }}" already exist: DLC znajdujący się w katalogu "{{ directoryName }}" już istnieje
+DLC associated with directory "{{ directoryName }}" already exist.: DLC znajdujący się w katalogu "{{ directoryName }}" już istnieje.
 
 # Steam Workshop Arma 3 Mod Url Validator
-Invalid Steam Workshop mod url: Błędny link do moda
-Mod not found: Nie znaleziono moda
-Url is not an Arma 3 mod: Mod nie jest modem do Arma 3
-Mod is either private or missing required details: Mod jest prywatny lub nie zawiera niezbędnych do jego dodania informacji
+Invalid Steam Workshop mod url.: Błędny link do moda.
+Mod not found.: Nie znaleziono moda.
+Url is not an Arma 3 mod.: Mod nie jest modem do Arma 3.
+Mod is either private or missing required details.: Mod jest prywatny lub nie zawiera niezbędnych do jego dodania informacji.
 
 # Steam Store Arma 3 Dlc Url Validator
-Invalid Steam Workshop DLC url: Błędny link do DLC
-DLC not found: Nie znaleziono DLC
-Url is not an Arma 3 DLC: DLC nie jest dodatkiem do Arma 3
+Invalid Steam Workshop DLC url.: Błędny link do DLC.
+DLC not found.: Nie znaleziono DLC.
+Url is not an Arma 3 DLC.: DLC nie jest dodatkiem do Arma 3.
 
 # Windows Directory Name Validator
-Invalid directory name: Błędny format nazwy katalogu
+Invalid directory name.: Błędny format nazwy katalogu.
 
 # Unique Mod List Name Validator
-Mod list with the same name "{{ modListName }}" already exist: Lista modów o nazwie "{{ modListName }}" już istnieje
+Mod list with the same name "{{ modListName }}" already exist.: Lista modów o nazwie "{{ modListName }}" już istnieje.
 
 # Unique Mod Group Name Validator
-Mod group with the same name "{{ modGroupName }}" already exist: Grupa modów o nazwie "{{ modGroupName }}" już istnieje
+Mod group with the same name "{{ modGroupName }}" already exist.: Grupa modów o nazwie "{{ modGroupName }}" już istnieje.
 
 # Unique User Group Name Validator
-User group with the same name "{{ userGroupName }}" already exist: Grupa użytkowników o nazwie "{{ userGroupName }}" już istnieje
+User group with the same name "{{ userGroupName }}" already exist.: Grupa użytkowników o nazwie "{{ userGroupName }}" już istnieje.