Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entities refactor #269

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Entities refactor #269

merged 1 commit into from
Aug 14, 2023

Conversation

jskowronski39
Copy link
Collaborator

@jskowronski39 jskowronski39 commented Aug 14, 2023 •
edited
Loading

This will:

  • Remove interfaces for entities
  • Remove setters; add behaviors to entities
  • Remove "type" property from AbstractMod and move it to SteamWorkshopMod
  • add few improvements in templates

This requires #268

@jskowronski39 jskowronski39 requested a review from a team as a code owner August 14, 2023 14:01
@jskowronski39 jskowronski39 requested review from veteran29 and removed request for a team August 14, 2023 14:01
Base automatically changed from feature/simplify_permissions_structure to dev August 14, 2023 19:01
@jskowronski39 jskowronski39 merged commit fc2bf8a into dev Aug 14, 2023
5 checks passed
@jskowronski39 jskowronski39 deleted the feature/entities-refactor branch August 14, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veteran29 veteran29 veteran29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jskowronski39 @veteran29