Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add identifier factory #326

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Add identifier factory #326

merged 1 commit into from
Mar 15, 2024

Conversation

jskowronski39
Copy link
Collaborator

This will:

  • Add IdentifierFactory which will allow us to generate predictable UUIDs during tests

@jskowronski39 jskowronski39 requested a review from a team as a code owner March 6, 2024 21:08
@jskowronski39 jskowronski39 requested review from veteran29 and removed request for a team March 6, 2024 21:08
@veteran29 veteran29 added the enhancement Fixes and improvements for existing feature label Mar 14, 2024
veteran29
veteran29 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I haven't inspected every change closely.

@jskowronski39 jskowronski39 merged commit 4402790 into dev Mar 15, 2024
5 checks passed
@jskowronski39 jskowronski39 deleted the feature/identifier-factory branch March 15, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veteran29 veteran29 veteran29 approved these changes

Assignees
No one assigned
Labels
enhancement Fixes and improvements for existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jskowronski39 @veteran29