Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to ArpNetworking parent pom and upgraded dependencies #21

Merged
merged 1 commit into from
Nov 25, 2015

Conversation

vjkoskela
Copy link
Member

No description provided.

@BrandonArp
Copy link
Member

Will merge when you fix the build.

@vjkoskela
Copy link
Member Author

Brandon, the issue here seems to be a race condition in the tests. I have been unable to repro it on my machine, but am still tracing through the tests and code looking for it. Will update once I find it or give up and just disable concurrent test execution (definitely not the preferable outcome).

@vjkoskela vjkoskela force-pushed the parent-pom branch 2 times, most recently from 5af1389 to 3a9514d Compare November 25, 2015 01:25
@vjkoskela
Copy link
Member Author

Alright, I've spent way too long on this. Since the tests were not executed in parallel prior to the parent pom migration I've simply disabled parallel execution by overriding the Surefire configuration from the ArpNetworking parent pom. We should definitely still investigate and resolve this issue as it could indicate a problem in the code (not necessarily in the tests). To this end I've filed issue #22.

BrandonArp added a commit that referenced this pull request Nov 25, 2015
Switched to ArpNetworking parent pom and upgraded dependencies
@BrandonArp BrandonArp merged commit 7f91321 into master Nov 25, 2015
@BrandonArp BrandonArp deleted the parent-pom branch November 25, 2015 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants