Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default ebean.properties with UTC timezone #432

Closed
wants to merge 3 commits into from

Conversation

cwbriones
Copy link
Contributor

Resolves #419.

See the issue for details. The short of it is that we already treat all unzoned times internally as UTC, mostly through the usage of Instant. Ebean by default however, uses the JVM timezone when it initializes its connection pool. This previously caused issues in tests, and so it was explicitly set to UTC there. This PR does the same by adding a default properties file.

@cwbriones
Copy link
Contributor Author

My thought process in adding this default is that we're making this usage explicit, and by doing it through standard configuration anyone who's deployed mportal without configuring this can continue to do so by changing the timezone in ebean.properties

@cwbriones
Copy link
Contributor Author

Alternatively - since this is properties file I might be mistaken in how easily overridden this is. If that's a problem I think we'll just have to resort to setting it ourselves in our deployment.

@cwbriones
Copy link
Contributor Author

Closing since I think it's another source of configuration that could actually go out of sync (rather than a single source, the JVM's timezone). Additionally the prior issue seems mostly like a test isolation problem rather than one with the system during normal operation.

@cwbriones cwbriones closed this Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EBeanServer should treat dates it receives as UTC
1 participant