adding tests for Bank::BIC and making valid_format? return a boolean …

…instead of an integer|nil

lib/bank/bic.rb

@@ -52,7 +52,7 @@ def valid_length?
     end
 
     def valid_format?
-      @code =~ /^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$/
+      !!(@code =~ /^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$/)
     end
 
     def valid_location_code?

spec/bic_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+
+
+describe Bank::BIC do
+  before do
+    @bic = Bank::BIC.new('ABNACHZ8XXX')
+  end
+
+  it 'returns the right bank code' do
+    @bic.bank_code.must_equal 'ABNA'
+  end
+
+  it 'returns the right country code' do
+    @bic.country_code.must_equal 'CH'
+  end
+
+  it 'returns the right location code' do
+    @bic.location_code.must_equal 'Z8'
+  end
+
+  it 'returns the right branch code' do
+    @bic.branch_code.must_equal 'XXX'
+  end
+
+  [ 8, 11 ].each do |len|
+    describe 'x'*len do
+      it "has a valid length" do
+        Bank::BIC.new('x'*len).valid_length?.must_equal true
+      end
+    end
+  end
+
+  1.upto(20) do |len|
+    if len != 8 && len != 11
+      describe 'x'*len do
+        it "has a valid length" do
+          Bank::BIC.new('x'*len).valid_length?.must_equal false
+        end
+      end
+    end
+  end
+
+  [ 'UCJAES2MXXX',
+    'ABAGATWWXXX',
+    'UCJAES2MXXX'
+  ].each do |code|
+    describe code do
+      it "has a valid format" do
+        Bank::BIC.new(code).valid_format?.must_equal true
+      end
+    end
+  end
+
+  [
+    '12341234'
+  ].each do |code|
+    describe code do
+      it "has an invalid format" do
+        Bank::BIC.new(code).valid_format?.must_equal false
+      end
+    end
+  end
+
+end

spec/spec_helper.rb

@@ -8,3 +8,4 @@
 
 require 'active_model'
 require 'bank/iban'
+require 'bank/bic'