#54 - [Game Service] Question generator and retriever

[adrianmfuentes]

I am opening this pull request in order to have feedback about the implementation of the game retriever, issue #54 , created by @carlosfernandezmartinez. This feedback is important before merging the changes to the master branch.

In this link you can find the game service package, where you can find all the classes implemented for this issue (there are also some classes of issue #53). My classes are:

• RouterQuestionRetriever

• Server

Disclaimer

To check the behavior please read the comments on issue #54

[carlosfernandezmartinez]

The service retrieves the whole set of questions of the DB. It should be configurable.

[adrianmfuentes]

Thanks for your feedback. It is true that returning the whole database is not practical, I did not think about it when developing the router, but thanks for figuring it out. Now the router is properly updated with two path variables, the first for the number of questions you want and the latter for the number of choices per question you want, as you can see here:

Note that, if no values are specified, by default, there will be 3 questions with 3 choices each (this can be changed whenever).

Also, I have added extra randomness to the questions selection from the ones retrieved by the database in order not to return them sequentially, as can be visualized in the following picture:

Please, review it and notify me if there are any changes or improvements needed.

[carlosfernandezmartinez]

Now everything's nice, even though you forgot to make the parameters optional, I fixed it for you 👵 ⛷️ 🥇

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud