Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#53 - Question fetcher finished #58

Merged
merged 11 commits into from
Mar 3, 2025
Merged

#53 - Question fetcher finished #58

merged 11 commits into from
Mar 3, 2025

Conversation

carlosfernandezmartinez

The question fetcher is finished. Have a look at the issue, where everything is well explained

@carlosfernandezmartinez carlosfernandezmartinez linked an issue Feb 24, 2025 that may be closed by this pull request
@adrianmfuentes adrianmfuentes requested review from adrianmfuentes and removed request for adrianmfuentes February 25, 2025 07:04
Copy link

@DavidPedregal DavidPedregal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected but the saving part. After fixing that, the branch will be merged

Copy link

@sergio-riesco sergio-riesco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create the folder before saving the images just in case the folder doesn't exist on the host machine, add something like:
// Set up image directory with proper permissions
await fs.mkdir('./public/images', { recursive: true, mode: 0o755 });

@sergio-riesco sergio-riesco merged commit 7c696f8 into master Mar 3, 2025
1 check passed
Copy link

sonarqubecloud bot commented Mar 3, 2025

@sergio-riesco sergio-riesco deleted the #53 branch March 4, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Game Service] Question fetcher component
3 participants