Fix new clippy warnings in 1.84 and update toolchain for CI (#826)

.github/workflows/ci.yml

@@ -32,9 +32,10 @@ jobs:
           distribution: 'temurin'
           java-version: '11'
       - name: Install Rust
-        uses: dtolnay/rust-toolchain@1.83
+        uses: dtolnay/rust-toolchain@master
         with:
           components: clippy, rustfmt
+          toolchain: 1.84
       - name: Check Formatting
         run: cargo fmt -- --check
       - uses: actions/setup-python@v5

crates/arroyo-api/src/jobs.rs

@@ -37,7 +37,7 @@ use crate::types::public::LogLevel;
 use crate::{queries::api_queries, to_micros, types::public, AuthData};
 use cornucopia_async::DatabaseSource;
 
-pub(crate) async fn create_job<'a>(
+pub(crate) async fn create_job(
     pipeline_name: &str,
     pipeline_id: i64,
     checkpoint_interval: Duration,

crates/arroyo-api/src/lib.rs

@@ -1,3 +1,6 @@
+// https://github.com/rust-lang/rust-clippy/issues/12908
+#![allow(clippy::needless_lifetimes)]
+
 use axum::response::IntoResponse;
 use axum::Json;
 use cornucopia_async::DatabaseSource;

crates/arroyo-api/src/pipelines.rs

@@ -58,7 +58,7 @@ use arroyo_types::to_millis;
 use cornucopia_async::{Database, DatabaseSource};
 use petgraph::prelude::EdgeRef;
 
-async fn compile_sql<'a>(
+async fn compile_sql(
     query: String,
     local_udfs: &Vec<Udf>,
     parallelism: usize,
@@ -291,7 +291,7 @@ async fn register_schemas(compiled_sql: &mut CompiledSql) -> anyhow::Result<()>
 }
 
 #[allow(clippy::too_many_arguments)]
-pub(crate) async fn create_pipeline_int<'a>(
+pub(crate) async fn create_pipeline_int(
     name: String,
     query: String,
     udfs: Vec<Udf>,

crates/arroyo-controller/src/lib.rs

@@ -1,6 +1,8 @@
 #![allow(clippy::new_without_default)]
 // TODO: factor out complex types
 #![allow(clippy::type_complexity)]
+// https://github.com/rust-lang/rust-clippy/issues/12908
+#![allow(clippy::needless_lifetimes)]
 
 use anyhow::Result;
 use arroyo_rpc::config;

crates/arroyo-server-common/src/lib.rs

@@ -212,11 +212,11 @@ struct AdminState {
     name: String,
 }
 
-async fn root<'a>(State(state): State<Arc<AdminState>>) -> String {
+async fn root(State(state): State<Arc<AdminState>>) -> String {
     format!("{}\n", state.name)
 }
 
-async fn status<'a>() -> String {
+async fn status() -> String {
     "ok".to_string()
 }
 
@@ -244,7 +244,7 @@ async fn config_route() -> Result<String, StatusCode> {
     Ok(toml::to_string(&*config()).unwrap())
 }
 
-async fn details<'a>(State(state): State<Arc<AdminState>>) -> String {
+async fn details(State(state): State<Arc<AdminState>>) -> String {
     serde_json::to_string_pretty(&json!({
         "service": state.name,
         "git_sha": GIT_SHA,