Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#322 some logos are not rendering #326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shibuya-r
Copy link

Issue: #322

What does this PR do?

Fixed some links to display project card logos/images.

スクリーンショット 2023-09-07 9 59 28

@welcome
Copy link

welcome bot commented Sep 7, 2023

💖Thanks for opening this pull request! Please check out our contributing guidelines.💖

@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starter-hive ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 1:16am

Copy link
Owner

@ArslanYM ArslanYM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you have manually changed the link to some of the project logos. But for some cards the issue still persists. Can you figure out whats causing this? Or is it just that the links are broken?

@shibuya-r
Copy link
Author

@ArslanYM
Thank you for your review.
Some image links are broken and some were missing 'raw' arguments.
All images are displayed in my environment, but which images are not displayed in your environment?

@ArslanYM
Copy link
Owner

ArslanYM commented Sep 8, 2023

@shibuya-r

Screenshots:
these


A few of these images still take time to load. And some of them are not rendering at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants