Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add No Issues Component #394

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Dhoni77
Copy link

@Dhoni77 Dhoni77 commented Nov 1, 2023

Fixes #392

  • No Issues Component to render text when issues are empty

Copy link

welcome bot commented Nov 1, 2023

💖Thanks for opening this pull request! Please check out our contributing guidelines.💖

Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starter-hive ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 8:50am

@ArslanYM
Copy link
Owner

ArslanYM commented Nov 1, 2023

I was expecting something better, similar to the 404 page. Can you come up with mocks before raising a PR?

something better

@Dhoni77
Copy link
Author

Dhoni77 commented Nov 1, 2023

Ok

export const IssueList = () => {
const location = useLocation();
const { issues } = location.state;
console.log(issues)
console.log(issues);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not leave a console.log here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⭐FEAT: Render a No issues found component for no issues
3 participants