Merge pull request #11 from ArthurClemens/handle-no-dataset

Handle empty dataset
ArthurClemens · Jan 1, 2023 · 815d3a3 · 815d3a3
2 parents 424883a + 96521a0
commit 815d3a3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/dist/dialogic-js.js b/dist/dialogic-js.js
@@ -118,7 +118,7 @@ var clearDataset = (cache, id) => {
   delete cache[id];
 };
 var applyDataset = (dataset, el) => {
-  if (!el)
+  if (!el || !dataset)
     return;
   Object.keys(dataset).forEach((key) => {
     el.dataset[key] = dataset[key];

diff --git a/dist/dialogic-js.min.js b/dist/dialogic-js.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "dialogic-js",
-  "version": "0.4.2",
+  "version": "0.4.3",
   "description": "Control the opening and closing of dialogs and menus using HTML and (optionally) vanilla JavaScript.",
   "types": "dist",
   "files": [

diff --git a/src/util.ts b/src/util.ts
@@ -129,7 +129,7 @@ export const applyDataset = (
   dataset: DOMStringMap,
   el?: HTMLElement | null
 ) => {
-  if (!el) return;
+  if (!el || !dataset) return;
   Object.keys(dataset).forEach((key) => {
     el.dataset[key] = dataset[key];
   });