Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added clear all drawing feature #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RaviRanjan-11
Copy link

No description provided.

@stevelandeyasana
Copy link
Collaborator

I'm not sure this is the right approach. I would have thought we would want to simply remove all shapes and reset the undo stack. Undoing every operation could be very expensive if there are many operations, whereas resetting the shape and undo stack lists would be very cheap.

@asherxiq
Copy link

This is not a perfect solution. It does have drawbacks when a user does save the drawing response and then again loads on the draw view. Definitely there will be no undo stack, in that case, the solution doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants