Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect when base text is used for other languages #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

taher-mosbah
Copy link

Thanks for this great tool, I have an improvement suggestion but not sure if it would be useful for everyone:
a common case is when developers is waiting for translation is to put the English (base) text for other languages and forget about it.

Cheers !

@stevelandeyasana
Copy link
Collaborator

Neat idea! I agree something like this would be useful, but I'm not sure it's ready to go in as-is, just because there isn't currently a way to silence specific instances of warnings. I'm imagining a case like "%d/%d", where it would be common for translations to be the same as the base language. I'm going to leave this open until we have that feature.

@JacobHearst
Copy link

JacobHearst commented Feb 22, 2022

This PR will resolve #33

Edit: This did not link the issue like I thought it would, not sure if that functionality is a repo setting or something

@alex-hunsley-nl
Copy link

If this feature is added, is it possible to allow it to be disabled by use of a flag? Our localization deliberately in some cases uses the same values in a translation as base. We do that because in some languages the app doesn't need translation in some areas (a feature isn't available in that country). But if we just omitted the key, locheck would complain about it being missing.

@stevelandeyasana
Copy link
Collaborator

stevelandeyasana commented Sep 12, 2022

This won't be merged until we have a general way of letting people opt out of rules, similar to what SwiftLint has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants