expose process.binding('util').getPromiseDetails #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the internalBinding for util and the Node 16+ external binding. Some methods are defined in both
and I haven't checked very carefully what happens with those, but they are all isType methods (eg isPromise)
so it would be pretty buggy if their behavior differed.
test plan:
build node, and verify I can access getPromiseDetails and use it to check if a promise is resolved