Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code for proposals and gateways, #28

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bassjobsen
Copy link
Contributor

@a1300
Copy link
Contributor

a1300 commented Sep 17, 2018

@bassjobsen the review to your pull request:

Review

npm install doesn't work. Please change the package.json file to the following:

1

- "asch-js": "github:a1300/asch-js#fix_1_4_api",
+ "asch-js": "github:aschplatform/asch-js#develop",

2

You are using TABS in the README.md file. Please use only spaces:
review

3

On Line 387 in api.js there is a lonely keyword. I think it can be deleted.

}activateproposal

4

Please change the casing of all new functions in api.js that consist of more then two words: registergateway -> registerGateway

5

Please add a description to the <secret> for the command registermember because it must be the description of the member that wants to be registered and not a account that manages the registration for them 🙂

Please change the small parts. Very good work! Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants