마이페이지 api 추가 #195
Open
마이페이지 api 추가 #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
6 tasks
eunnbi
reviewed
Apr 28, 2022
eunnbi
reviewed
Apr 28, 2022
eunnbi
reviewed
Apr 28, 2022
Comment on lines
50
to
59
| //이메일 중복 확인 | ||
| export const getUserEmailCheck = async (email) => { | ||
| const { data } = await axios.get(`${baseUrl}/emailCheck?email=${email}`); | ||
| if(data === true){ | ||
| alert('중복된 이메일입니다!') | ||
| } | ||
| else{ | ||
| return data; | ||
| } | ||
| }; |
There was a problem hiding this comment.
이렇게 코드 짜셔도 좋지만 react query의 useQuery에서 query function은 api 요청해서 받은 data를 반환을 해야 해서 다른 함수들처럼 바로 data를 반환해야 할 거예요. if문 안 로직의 경우에는 useQuery에서 onSuccess를 이용하면 되서 로직을 함수 밖으로 옮기셔야 할 거 같아요!
eunnbi
reviewed
Apr 29, 2022
src/lib/api/user.js
Outdated
Comment on lines
45
to
48
| onSuccess: () => { | ||
| if(data === false){ | ||
| return data; | ||
| } |
There was a problem hiding this comment.
onSuccess는 useQuery 함수 인자로 들어가는 거라서 이렇게 작성하시면 에러가 날거예요. return data로 코드 수정해주세요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.