-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deepanshutr/chore #435
Deepanshutr/chore #435
Commits on Mar 7, 2024
-
fix(query_request_test):Refactor query tests to use key instead of IDs
The test cases in several query modules have been refactored. The order, meta, asset, and maintainer modules now use keys instead of IDs for test cases. This involves updating the relevant fields and test data. The change enhances code consistency and test coverage for the application.
Configuration menu - View commit details
-
Copy full SHA for 7d23bc6 - Browse repository at this point
Copy the full SHA 7d23bc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9532d8a - Browse repository at this point
Copy the full SHA 9532d8aView commit details
Commits on Mar 8, 2024
-
feat(utilities):Add GenerateUniqueIdentifierList function in id.go
This commit adds a new function GenerateUniqueIdentifierList in the utilities module. The function generates a list of unique IDs with a given prefix and count, which can be used for testing and client utility purposes.
Configuration menu - View commit details
-
Copy full SHA for c5317e4 - Browse repository at this point
Copy the full SHA c5317e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7810636 - Browse repository at this point
Copy the full SHA 7810636View commit details
Commits on Mar 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b60f26a - Browse repository at this point
Copy the full SHA b60f26aView commit details
Commits on Mar 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fd2a0ea - Browse repository at this point
Copy the full SHA fd2a0eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec288dd - Browse repository at this point
Copy the full SHA ec288ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ada41f - Browse repository at this point
Copy the full SHA 9ada41fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc0f951 - Browse repository at this point
Copy the full SHA bc0f951View commit details
Commits on Mar 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9cb2c94 - Browse repository at this point
Copy the full SHA 9cb2c94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16a3fb4 - Browse repository at this point
Copy the full SHA 16a3fb4View commit details -
chore(helpers): Update tests and add error handling to auxiliary module
Added error handling for the auxiliary module and expanded test coverage for better integrity checking and robustness. Improved tests in the helpers/base package, especially for auxiliaries and cli_flag. Updated error handling and validations for auxiliary initializations and operations to prevent panics and ensure data integrity.
Configuration menu - View commit details
-
Copy full SHA for e0a7255 - Browse repository at this point
Copy the full SHA e0a7255View commit details
Commits on Mar 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f79a53f - Browse repository at this point
Copy the full SHA f79a53fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bf2be8 - Browse repository at this point
Copy the full SHA 6bf2be8View commit details
Commits on Mar 19, 2024
-
fix(transaction_keeper_test):Update import paths and enhance helper f…
…unctions in transaction_keeper_test.go The changes involve updating import paths to retrieve necessary modules like orders, identities, metas, classifications, and dependencies like cosmos-sdk or IBC modules from github. The transaction_keeper test has major enhancements which mainly revolve around creating a more comprehensive test setup as well as updating the parameters for wrapping transactions.
Configuration menu - View commit details
-
Copy full SHA for 9411e31 - Browse repository at this point
Copy the full SHA 9411e31View commit details
Commits on Mar 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1244f96 - Browse repository at this point
Copy the full SHA 1244f96View commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 026086b - Browse repository at this point
Copy the full SHA 026086bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7e6012 - Browse repository at this point
Copy the full SHA b7e6012View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e3345c - Browse repository at this point
Copy the full SHA 1e3345cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a4efb5 - Browse repository at this point
Copy the full SHA 4a4efb5View commit details
Commits on Mar 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9f2a984 - Browse repository at this point
Copy the full SHA 9f2a984View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56f5693 - Browse repository at this point
Copy the full SHA 56f5693View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4b6997 - Browse repository at this point
Copy the full SHA f4b6997View commit details -
Configuration menu - View commit details
-
Copy full SHA for 266e0f2 - Browse repository at this point
Copy the full SHA 266e0f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8314812 - Browse repository at this point
Copy the full SHA 8314812View commit details
Commits on Mar 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4f416b4 - Browse repository at this point
Copy the full SHA 4f416b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52193bc - Browse repository at this point
Copy the full SHA 52193bcView commit details
Commits on Mar 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fa66ea6 - Browse repository at this point
Copy the full SHA fa66ea6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 727e4b5 - Browse repository at this point
Copy the full SHA 727e4b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6452660 - Browse repository at this point
Copy the full SHA 6452660View commit details -
Configuration menu - View commit details
-
Copy full SHA for 145778e - Browse repository at this point
Copy the full SHA 145778eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 175a86e - Browse repository at this point
Copy the full SHA 175a86eView commit details
Commits on Apr 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6e38656 - Browse repository at this point
Copy the full SHA 6e38656View commit details
Commits on Apr 5, 2024
-
refactor(wrap):Refactor error messages in ValidateBasic function
Instead of directly returning the error in ValidateBasic function, the error messages are now wrapped with details for better debugging. This change mainly affects the error handling mechanism within the sdkTypes.AccAddressFromBech32, FromID.ValidateBasic, and Coins.Validate functions, and also refines the coins length error message.
Configuration menu - View commit details
-
Copy full SHA for 189fe52 - Browse repository at this point
Copy the full SHA 189fe52View commit details -
test(wrap):Add advanced test cases for ValidateBasic method
The update adds various new test cases to the ValidateBasic method in message_test.go. These cover scenarios like multiple coins, duplicate denom, and an excessive number of coins. New invalid request errors have been added to handle incorrect from address, from id, coin amount and coin denom.
Configuration menu - View commit details
-
Copy full SHA for 1f0da68 - Browse repository at this point
Copy the full SHA 1f0da68View commit details -
refactor(wrap):Refactor error messages in ValidateBasic function
Instead of directly returning the error in ValidateBasic function, the error messages are now wrapped with details for better debugging. This change mainly affects the error handling mechanism within the sdkTypes.AccAddressFromBech32, FromID.ValidateBasic, and Coins.Validate functions, and also refines the coins length error message.
Configuration menu - View commit details
-
Copy full SHA for 3263633 - Browse repository at this point
Copy the full SHA 3263633View commit details -
test(wrap):Add advanced test cases for ValidateBasic method
The update adds various new test cases to the ValidateBasic method in message_test.go. These cover scenarios like multiple coins, duplicate denom, and an excessive number of coins. New invalid request errors have been added to handle incorrect from address, from id, coin amount and coin denom.
Configuration menu - View commit details
-
Copy full SHA for 0611c7c - Browse repository at this point
Copy the full SHA 0611c7cView commit details -
refactor(send):Refactor error messages in ValidateBasic function
Instead of directly returning the error in ValidateBasic function, the error messages are now wrapped with details for better debugging. This change mainly affects the error handling mechanism within the sdkTypes.AccAddressFromBech32, FromID.ValidateBasic, and Coins.Validate functions, and also refines the coins length error message.
Configuration menu - View commit details
-
Copy full SHA for 30f190c - Browse repository at this point
Copy the full SHA 30f190cView commit details -
test(send):Add comprehensive tests for Message validation
Expanded message_test.go with various test cases that cover scenarios for validating basic Message fields, including address, ID, asset, and value. These tests ensure that the correct error handling occurs for all possible cases in the validation process.
Configuration menu - View commit details
-
Copy full SHA for bc08883 - Browse repository at this point
Copy the full SHA bc08883View commit details -
refactor(assets):Refactor error handling in message validation
This update replaces usage of generic error messages in message validation methods of wrap, unwrap, and send transactions. These have been replaced with custom errors for invalid situations such as incorrect address, invalid id, etc. This provides more clear debugging information and improves error tracking.
Configuration menu - View commit details
-
Copy full SHA for 697ad21 - Browse repository at this point
Copy the full SHA 697ad21View commit details -
refactor(errors):Refactor error names from "IncorrectMessage" to "Inv…
…alidMessage" The error name "IncorrectMessage" has been refactored to "InvalidMessage" throughout the codebase to better reflect its meaning. This change affects all modules and tests where this error name is used, improving code clarity and consistency.
Configuration menu - View commit details
-
Copy full SHA for 3864de6 - Browse repository at this point
Copy the full SHA 3864de6View commit details
Commits on Apr 12, 2024
-
chore(split/utilities): removing unnecessary checks,
improving error message
Configuration menu - View commit details
-
Copy full SHA for 1c1731e - Browse repository at this point
Copy the full SHA 1c1731eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03f6a22 - Browse repository at this point
Copy the full SHA 03f6a22View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3c4347 - Browse repository at this point
Copy the full SHA e3c4347View commit details -
fix(splits/transfer):Update validation in transfer auxiliaryRequest
The validation in transfer's auxiliaryRequest struct has been updated to use ValidateBasic() function rather than using govalidator. This change provides a more specific validation ensuring the IDs are valid and the value is greater than zero.
Configuration menu - View commit details
-
Copy full SHA for 185f278 - Browse repository at this point
Copy the full SHA 185f278View commit details -
Configuration menu - View commit details
-
Copy full SHA for fee1545 - Browse repository at this point
Copy the full SHA fee1545View commit details -
Configuration menu - View commit details
-
Copy full SHA for fef5214 - Browse repository at this point
Copy the full SHA fef5214View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e180ef - Browse repository at this point
Copy the full SHA 5e180efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a88281 - Browse repository at this point
Copy the full SHA 3a88281View commit details -
Refactor validation in mint auxiliary request
The validation process in the mint auxiliary request class of the x splits module was revamped. Instead of using the 'govalidator' package for validation, each attribute is now individually validated using 'ValidateBasic' method and error messages are handled more precisely.
Configuration menu - View commit details
-
Copy full SHA for a99b339 - Browse repository at this point
Copy the full SHA a99b339View commit details -
Remove auxiliaryRequestFromInterface test
The test method Test_auxiliaryRequestFromInterface has been removed from the mint auxiliary request test file in the x splits module. This change simplifies the test structure and streamlines the module by eliminating unnecessary testing of auxiliaryRequestFromInterface function.
Configuration menu - View commit details
-
Copy full SHA for fef95cf - Browse repository at this point
Copy the full SHA fef95cfView commit details -
Update auxiliary tests in mint module
Revised auxiliary tests in the mint module of the x splits package. Unnecessary test cases have been removed, including testing of auxiliaryRequestFromInterface function. Also, new test scenarios were added for improved code coverage and validity checks. The helper function "createTestInput" was removed and replaced with global variables for better readability and consistency.
Configuration menu - View commit details
-
Copy full SHA for d459f70 - Browse repository at this point
Copy the full SHA d459f70View commit details -
Improve validation and error handling in mint module
Refactored the Help function in the mint module's auxiliary helper to enhance input validation and error handling. It now validates the AuxiliaryRequest explicitly and returns custom error for invalid request type. This update ensures more robust code execution and improved debugging capability.
Configuration menu - View commit details
-
Copy full SHA for d6d14e3 - Browse repository at this point
Copy the full SHA d6d14e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f32fc84 - Browse repository at this point
Copy the full SHA f32fc84View commit details -
Removed obsolete auxiliaryRequestFromInterface test
This commit removes the 'Test_auxiliaryRequestFromInterface' function from the 'auxiliary_request_test.go' file. The test was deemed unnecessary and not contributing any value to the testing suite.
Configuration menu - View commit details
-
Copy full SHA for 44b61e6 - Browse repository at this point
Copy the full SHA 44b61e6View commit details -
Refactor validation in auxiliaryRequest
This commit replaces the govalidator usage for auxiliaryRequest validation with custom error checking. It also removes unnecessary `valid` struct tags and enhances error messages. Now validation checks for specifics: the validity of both owner ids, asset ids and makes sure that value is greater than zero.
Configuration menu - View commit details
-
Copy full SHA for ac6d5e6 - Browse repository at this point
Copy the full SHA ac6d5e6View commit details -
Refactor auxiliaryRequest validation and tests
This commit refactors the process of validation in auxiliaryRequest and its corresponding test cases. The update replaces the use of govalidator with custom error checking, removes unnecessary 'valid' struct tags, and enhances the clarity of error messages. The validation now specifically checks the validity of the owner and asset IDs, and ensures that the value is greater than zero.
Configuration menu - View commit details
-
Copy full SHA for adac516 - Browse repository at this point
Copy the full SHA adac516View commit details -
Enhance validation for auxiliary request
The updated code includes enhanced validation processes in the auxiliary request function, now using custom error checking. It ensures the validity of the owner and asset IDs and checks that the value is greater than zero. It also offers improved error messages by replacing govalidator, removing unnecessary 'valid' struct tags and therefore making the overall testing more concise and clear.
Configuration menu - View commit details
-
Copy full SHA for 5fdd1dd - Browse repository at this point
Copy the full SHA 5fdd1ddView commit details